File fix-signedness-warning.patch of Package qpdf

Overview Repositories Revisions Requests Users Attributes Meta

File fix-signedness-warning.patch of Package qpdf (Revision 708cf3bc7eae62f1b1d954042f903be6)

Currently displaying revision 708cf3bc7eae62f1b1d954042f903be6 , Show latest

From d7ab3b42b3c7278ddf08c22676cd544ceb96c51c Mon Sep 17 00:00:00 2001
From: Jay Berkenbilt <ejb@ql.org>
Date: Mon, 10 Jan 2022 11:52:07 -0500
Subject: [PATCH] Fix signed/unsigned char warning (fixes #604)

---
 libqpdf/QPDFTokenizer.cc | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/libqpdf/QPDFTokenizer.cc b/libqpdf/QPDFTokenizer.cc
index 4217575c1..f4439fd1a 100644
--- a/libqpdf/QPDFTokenizer.cc
+++ b/libqpdf/QPDFTokenizer.cc
@@ -719,7 +719,7 @@ QPDFTokenizer::findEI(PointerHolder<InputSource> input)
                 for (std::string::iterator iter = value.begin();
                      iter != value.end(); ++iter)
                 {
-                    signed char ch = *iter;
+                    char ch = *iter;
                     if (((ch >= 'a') && (ch <= 'z')) ||
                         ((ch >= 'A') && (ch <= 'Z')) ||
                         (ch == '*'))
@@ -729,10 +729,11 @@ QPDFTokenizer::findEI(PointerHolder<InputSource> input)
                         // alphabetic characters.
                         found_alpha = true;
                     }
-                    else if ((ch < 32) && (! isSpace(ch)))
+                    else if ((static_cast<signed char>(ch) < 32) &&
+                             (! isSpace(ch)))
                     {
-                        // ch is signed, so characters outside of
-                        // 7-bit will be < 0.
+                        // Compare ch as a signed char so characters
+                        // outside of 7-bit will be < 0.
                         found_non_printable = true;
                         break;
                     }

Places

File fix-signedness-warning.patch of Package qpdf (Revision 708cf3bc7eae62f1b1d954042f903be6)

Places