File pvcreate-remove-recent-warning-message.patch of Package lvm2

Overview Repositories Revisions Requests Users Attributes Meta

File pvcreate-remove-recent-warning-message.patch of Package lvm2 (Revision e9a6ea4d412c8fbde66afc1aa87906cb)

Currently displaying revision e9a6ea4d412c8fbde66afc1aa87906cb , Show latest

From 074295245b3f57310a2688a4628f016b17ba2f5d Mon Sep 17 00:00:00 2001
From: David Teigland <teigland@redhat.com>
Date: Thu, 9 Jul 2015 15:26:32 -0500
Subject: [PATCH] pvcreate: remove recent warning message

log_warn was added recently because no known code used
the given condition, but running pvcreate on an existing
PV uses this case, and should not produce a warning.

References: bsc#966183
---
 lib/cache/lvmcache.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c
index d44f9d4..9f5b83a 100644
--- a/lib/cache/lvmcache.c
+++ b/lib/cache/lvmcache.c
@@ -1856,14 +1856,12 @@ struct lvmcache_info *lvmcache_add(struct labeller *labeller, const char *pvid,
 		}
 
 		/*
-		 * FIXME: when could this ever happen?
-		 * If this does happen, identify when/why here, and
-		 * if not, remove this code.
+		 * This happens when running pvcreate on an existing PV.
 		 */
 		if (strcmp(pvid_s, existing->dev->pvid))  {
-			log_warn("Replacing dev %s pvid %s with dev %s pvid %s",
-				 dev_name(existing->dev), existing->dev->pvid,
-				 dev_name(dev), pvid_s);
+			log_verbose("Replacing dev %s pvid %s with dev %s pvid %s",
+				    dev_name(existing->dev), existing->dev->pvid,
+				    dev_name(dev), pvid_s);
 		}
 
 		/*
-- 
1.8.4.5

Places

File pvcreate-remove-recent-warning-message.patch of Package lvm2 (Revision e9a6ea4d412c8fbde66afc1aa87906cb)

Places