openSUSE Build Service

Overview Repositories Revisions Requests Users Attributes Meta

File fix-build.patch of Package kwin5 (Revision 391cb8b37b82979b6c101d1481a67818)

Currently displaying revision 391cb8b37b82979b6c101d1481a67818 , Show latest

From: Sebastian Kügler <sebas@kde.org>
Date: Thu, 15 Sep 2016 11:59:25 +0000
Subject: parent qaction in test
X-Git-Url: http://quickgit.kde.org/?p=kwin.git&a=commitdiff&h=1d37b92d85c73751e9797514710ecbf8d92c4f92
---
parent qaction in test

Summary:
My compiler doesn't seem to like this constructor, it bails out with the
following error:

/home/sebas/kf5/src/kde/workspace/kwin/autotests/integration/globalshortcuts_test.cpp:
In member function ‘void GlobalShortcutsTest::testConsumedShift()’:
/home/sebas/kf5/src/kde/workspace/kwin/autotests/integration/globalshortcuts_test.cpp:79:40:
error: no matching function for call to ‘QAction::QAction()’
QScopedPointer<QAction> action(new QAction);
^~~~~~~

Using this as first argument fixes the build on my machine.

Test Plan: screenedges test fails, others pass. (this screenedges test failure seems unrelated)

Reviewers: graesslin

Reviewed By: graesslin

Subscribers: luebking, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D2782
---

--- a/autotests/integration/globalshortcuts_test.cpp
+++ b/autotests/integration/globalshortcuts_test.cpp
@@ -76,7 +76,7 @@
 {
     // this test verifies that a shortcut with a consumed shift modifier triggers
     // create the action
-    QScopedPointer<QAction> action(new QAction);
+    QScopedPointer<QAction> action(new QAction(nullptr));
     action->setProperty("componentName", QStringLiteral(KWIN_NAME));
     action->setObjectName(QStringLiteral("globalshortcuts-test-consumed-shift"));
     QSignalSpy triggeredSpy(action.data(), &QAction::triggered);

Places

File fix-build.patch of Package kwin5 (Revision 391cb8b37b82979b6c101d1481a67818)

Places