File 0001-Fix-performance-issues-when-handling-layou... of Package libqt5-qtdeclarative

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-performance-issues-when-handling-layout-changed-.patch of Package libqt5-qtdeclarative (Revision 8e38328dea23ea1323c29e2154417b72)

Currently displaying revision 8e38328dea23ea1323c29e2154417b72 , Show latest

From 84f61dd2d2b0140814b39a2c5238a6e31c49abd7 Mon Sep 17 00:00:00 2001
From: Milian Wolff <milian.wolff@kdab.com>
Date: Thu, 31 Mar 2016 19:32:59 +0200
Subject: [PATCH 40/57] Fix performance issues when handling layout changed in
 Quick item views.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When the layout changes, we mark all rows as changed but do not track
where the individual rows get moved.

The only reason why one would want to track the moves is to persist
the current item selection across a layout change. But even the previous
code did not achieve that. I'll create a follow up patch to this one
that also implements this behavior as seen in Qt Widget item views.

Note that removing this code brings a tremendous performance win
on larger models. The repeated calls to _q_itemsMoved triggered O(n^2)
behavior in the number of top items in the model. Even with "only"
tens of thousands of items in the model, a layout change became very
costly and took seconds on a beefy modern desktop machine.

Calling _q_itemsMoved in a loop is bad because it:

- leads to O(N^2) behavior within QQmlChangeSet when merging the small
  moves into the item view's current change set
- potentially triggers tons of binding/property updates when the cached
  model indices are updated in _q_itemsMoved

Removing this slow path, I did not yet find a behavior change to the
previous code. Instead, it just does it all much faster.

Change-Id: I67fa99a1c5d8e05d17497d29391da9458bd9bdd0
Task-number: QTBUG-51638
Reviewed-by: Daniel Vrátil <daniel.vratil@kdab.com>
Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
---
 src/qml/types/qqmldelegatemodel.cpp   | 37 +----------------------------------
 src/qml/types/qqmldelegatemodel_p.h   |  1 -
 src/qml/types/qqmldelegatemodel_p_p.h |  2 --
 src/qml/util/qqmladaptormodel.cpp     |  4 ----
 4 files changed, 1 insertion(+), 43 deletions(-)

Index: qtdeclarative-opensource-src-5.7.0-beta/src/qml/types/qqmldelegatemodel.cpp
===================================================================
--- qtdeclarative-opensource-src-5.7.0-beta.orig/src/qml/types/qqmldelegatemodel.cpp
+++ qtdeclarative-opensource-src-5.7.0-beta/src/qml/types/qqmldelegatemodel.cpp
@@ -1559,29 +1559,6 @@ bool QQmlDelegateModel::isDescendantOf(c
     return false;
 }
 
-void QQmlDelegateModel::_q_layoutAboutToBeChanged(const QList<QPersistentModelIndex> &parents, QAbstractItemModel::LayoutChangeHint hint)
-{
-    Q_D(QQmlDelegateModel);
-    if (!d->m_complete)
-        return;
-
-    if (hint == QAbstractItemModel::VerticalSortHint) {
-        d->m_storedPersistentIndexes.clear();
-        if (!parents.isEmpty() && d->m_adaptorModel.rootIndex.isValid() &&  !isDescendantOf(d->m_adaptorModel.rootIndex, parents)) {
-            return;
-        }
-
-        for (int i = 0; i < d->m_count; ++i) {
-            const QModelIndex index = d->m_adaptorModel.aim()->index(i, 0, d->m_adaptorModel.rootIndex);
-            d->m_storedPersistentIndexes.append(index);
-        }
-    } else if (hint == QAbstractItemModel::HorizontalSortHint) {
-        // Ignored
-    } else {
-        // Triggers model reset, no preparations for that are needed
-    }
-}
-
 void QQmlDelegateModel::_q_layoutChanged(const QList<QPersistentModelIndex> &parents, QAbstractItemModel::LayoutChangeHint hint)
 {
     Q_D(QQmlDelegateModel);
@@ -1593,19 +1570,7 @@ void QQmlDelegateModel::_q_layoutChanged
             return;
         }
 
-        for (int i = 0, c = d->m_storedPersistentIndexes.count(); i < c; ++i) {
-            const QPersistentModelIndex &index = d->m_storedPersistentIndexes.at(i);
-            if (i == index.row())
-                continue;
-
-            _q_itemsMoved(i, index.row(), 1);
-        }
-
-        d->m_storedPersistentIndexes.clear();
-
-        // layoutUpdate does not necessarily have any move changes, but it can
-        // also mean data changes. We can't detect what exactly has changed, so
-        // just emit it for all items
+        // mark all items as changed
         _q_itemsChanged(0, d->m_count, QVector<int>());
 
     } else if (hint == QAbstractItemModel::HorizontalSortHint) {
Index: qtdeclarative-opensource-src-5.7.0-beta/src/qml/types/qqmldelegatemodel_p.h
===================================================================
--- qtdeclarative-opensource-src-5.7.0-beta.orig/src/qml/types/qqmldelegatemodel_p.h
+++ qtdeclarative-opensource-src-5.7.0-beta/src/qml/types/qqmldelegatemodel_p.h
@@ -146,7 +146,6 @@ private Q_SLOTS:
     void _q_rowsRemoved(const QModelIndex &,int,int);
     void _q_rowsMoved(const QModelIndex &, int, int, const QModelIndex &, int);
     void _q_dataChanged(const QModelIndex&,const QModelIndex&,const QVector<int> &);
-    void _q_layoutAboutToBeChanged(const QList<QPersistentModelIndex>&, QAbstractItemModel::LayoutChangeHint);
     void _q_layoutChanged(const QList<QPersistentModelIndex>&, QAbstractItemModel::LayoutChangeHint);
 
 private:
Index: qtdeclarative-opensource-src-5.7.0-beta/src/qml/types/qqmldelegatemodel_p_p.h
===================================================================
--- qtdeclarative-opensource-src-5.7.0-beta.orig/src/qml/types/qqmldelegatemodel_p_p.h
+++ qtdeclarative-opensource-src-5.7.0-beta/src/qml/types/qqmldelegatemodel_p_p.h
@@ -337,8 +337,6 @@ public:
         };
         QQmlDelegateModelGroup *m_groups[Compositor::MaximumGroupCount];
     };
-
-    QList<QPersistentModelIndex> m_storedPersistentIndexes;
 };
 
 class QQmlPartsModel : public QQmlInstanceModel, public QQmlDelegateModelGroupEmitter
Index: qtdeclarative-opensource-src-5.7.0-beta/src/qml/util/qqmladaptormodel.cpp
===================================================================
--- qtdeclarative-opensource-src-5.7.0-beta.orig/src/qml/util/qqmladaptormodel.cpp
+++ qtdeclarative-opensource-src-5.7.0-beta/src/qml/util/qqmladaptormodel.cpp
@@ -470,8 +470,6 @@ public:
                                 vdm, SLOT(_q_rowsMoved(QModelIndex,int,int,QModelIndex,int)));
             QObject::disconnect(aim, SIGNAL(modelReset()),
                                 vdm, SLOT(_q_modelReset()));
-            QObject::disconnect(aim, SIGNAL(layoutAboutToBeChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)),
-                                vdm, SLOT(_q_layoutAboutToBeChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)));
             QObject::disconnect(aim, SIGNAL(layoutChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)),
                                 vdm, SLOT(_q_layoutChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)));
         }
@@ -928,8 +926,6 @@ void QQmlAdaptorModel::setModel(const QV
                               vdm, QQmlDelegateModel, SLOT(_q_rowsMoved(QModelIndex,int,int,QModelIndex,int)));
             qmlobject_connect(model, QAbstractItemModel, SIGNAL(modelReset()),
                               vdm, QQmlDelegateModel, SLOT(_q_modelReset()));
-            qmlobject_connect(model, QAbstractItemModel, SIGNAL(layoutAboutToBeChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)),
-                              vdm, QQmlDelegateModel, SLOT(_q_layoutAboutToBeChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)));
             qmlobject_connect(model, QAbstractItemModel, SIGNAL(layoutChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)),
                               vdm, QQmlDelegateModel, SLOT(_q_layoutChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)));
         } else {

Places

File 0001-Fix-performance-issues-when-handling-layout-changed-.patch of Package libqt5-qtdeclarative (Revision 8e38328dea23ea1323c29e2154417b72)

Places