File 0001-Don-t-draw-focus-line-on-selected-list-ite... of Package breeze4-style

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Don-t-draw-focus-line-on-selected-list-item.patch of Package breeze4-style (Revision 2bbd56bb610ad488775a429358dd8c03)

Currently displaying revision 2bbd56bb610ad488775a429358dd8c03 , Show latest

From 4fd4a764b5bcd24fad0b60776fa0e38d6692481a Mon Sep 17 00:00:00 2001
From: Fabian Vogt <fabian@ritter-vogt.de>
Date: Fri, 7 Jul 2017 11:08:36 +0200
Subject: [PATCH] Don't draw focus line on selected list item

Summary: A fix I did for the focus line being drawn outside item boundaries resulted in the item selection rectangle being "cut off" by the focus line. The selection rectangle is enough of an indication anyway.

Test Plan:
Before
{F3805982}
After
{F3805984}

Focus line still shown when the item is not selected:
{F3805987}

Especially noticeable in KInfoCenter where there's a tree list and only the label is underlined but not the icon, resulting in an uneven "cut".

Reviewers: #plasma, hpereiradacosta, fvogt

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6544
---
 kstyle/breezestyle.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kstyle/breezestyle.cpp b/kstyle/breezestyle.cpp
index d3f6d46b..c1ae0d0a 100644
--- a/kstyle/breezestyle.cpp
+++ b/kstyle/breezestyle.cpp
@@ -3075,6 +3075,11 @@ namespace Breeze
         #endif
 
         const State& state( option->state );
+
+        // no focus indicator on selected list items
+        if (widget && widget->inherits("QAbstractItemView") && (state & State_Selected))
+        { return true; }
+
         const QRect rect( option->rect.adjusted( 0, 0, 0, 1 ) );
         const QPalette& palette( option->palette );
 
-- 
2.13.2

Places

File 0001-Don-t-draw-focus-line-on-selected-list-item.patch of Package breeze4-style (Revision 2bbd56bb610ad488775a429358dd8c03)

Places