File 0003-fix-double-free-in-grub_net_recv_tcp_packe... of Package grub2

Overview Repositories Revisions Requests Users Attributes Meta

File 0003-fix-double-free-in-grub_net_recv_tcp_packet.patch of Package grub2 (Revision 6bc455d2f2a52e411d570dd46c401833)

Currently displaying revision 6bc455d2f2a52e411d570dd46c401833 , Show latest

From 06eadf5ebf21c8520d696c6438a976e5f7c218c3 Mon Sep 17 00:00:00 2001
From: Curtis Larsen <larsen@dixie.edu>
Date: Sun, 7 Dec 2014 11:28:57 +0300
Subject: [PATCH] fix double free in grub_net_recv_tcp_packet

Using the http module to download config files, produces memory errors,
after the config file is downloaded.

The error was traced to the tcp stack in grub-core/net/tcp.c. The wrong
netbuff pointer was being freed in the clean up loop.

Changing the code to free the correct netbuff pointer removes the runtime
error.

Closes 42765.
---
 ChangeLog           | 5 +++++
 grub-core/net/tcp.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Index: grub-2.02~beta2/grub-core/net/tcp.c
===================================================================
--- grub-2.02~beta2.orig/grub-core/net/tcp.c
+++ grub-2.02~beta2/grub-core/net/tcp.c
@@ -918,7 +918,7 @@ grub_net_recv_tcp_packet (struct grub_ne
 	      do_ack = 1;
 	    }
 	  else
-	    grub_netbuff_free (nb);
+	    grub_netbuff_free (nb_top);
 	}
       if (do_ack)
 	ack (sock);

Places

File 0003-fix-double-free-in-grub_net_recv_tcp_packet.patch of Package grub2 (Revision 6bc455d2f2a52e411d570dd46c401833)

Places