File fix-crash-when-exiting-kscreen-kcm-in-systemset... of Package kscreen5

Overview Repositories Revisions Requests Users Attributes Meta

File fix-crash-when-exiting-kscreen-kcm-in-systemsettings.patch of Package kscreen5 (Revision d174dcdaf8115d2a6949e2bfd702135a)

Currently displaying revision d174dcdaf8115d2a6949e2bfd702135a , Show latest

From: Martin Gräßlin <mgraesslin@kde.org>
Date: Wed, 21 Oct 2015 08:30:58 +0000
Subject: Fix crash when exiting kscreen kcm in systemsettings
X-Git-Url: http://quickgit.kde.org/?p=kscreen.git&a=commitdiff&h=4653c287f844f2cb19379ff001ca76d7d9e3a2a1
---
Fix crash when exiting kscreen kcm in systemsettings

When using threaded rendering loop [1] systemsettings crashed when
clicking the back button. This crash is caused inside the shader effect
used by the OpacityMask.
QtQuick informed us also that something is wrong:
"QSGDefaultLayer::bind: ShaderEffectSource: 'recursive' must be set to true when rendering recursively."

The actual problem is that orientationPanelContainer and the OpacityMask
are children to the monitor item causing recursion. By making them
siblings to the orientationPanelContainer the problem is resolved. The
error message from QtQuick is no longer shown and systemsettings doesn't
crash any more.

BUG: 344651
FIXED-IN: 5.4.3
REVIEW: 125734

[1] QSG_RENDER_LOOP=threaded systemsettings5
---

--- a/kcm/qml/Output.qml
+++ b/kcm/qml/Output.qml
@@ -249,40 +249,39 @@
                     }
                 }
             }
-
-            Item {
-                id: orientationPanelContainer;
-
-                anchors.fill: monitor;
-
-                visible: false
-
-                Rectangle {
-                    id: orientationPanel;
-
-                    anchors {
-                        left: parent.left;
-                        right: parent.right;
-                        bottom: parent.bottom;
-                    }
-
-                    height: 10;
-                    color: root.focus ? palette.highlight : palette.shadow;
-                    smooth: true;
-
-                    Behavior on color {
-                        PropertyAnimation {
-                            duration: 150;
-                        }
-                    }
-                }
-            }
-
-            OpacityMask {
-                anchors.fill: orientationPanelContainer;
-                source: orientationPanelContainer;
-                maskSource: monitor;
-            }
+        }
+        Item {
+            id: orientationPanelContainer;
+
+            anchors.fill: monitor;
+
+            visible: false
+
+            Rectangle {
+                id: orientationPanel;
+
+                anchors {
+                    left: parent.left;
+                    right: parent.right;
+                    bottom: parent.bottom;
+                }
+
+                height: 10;
+                color: root.focus ? palette.highlight : palette.shadow;
+                smooth: true;
+
+                Behavior on color {
+                    PropertyAnimation {
+                        duration: 150;
+                    }
+                }
+            }
+        }
+
+        OpacityMask {
+            anchors.fill: orientationPanelContainer;
+            source: orientationPanelContainer;
+            maskSource: monitor;
         }
     }

Places

File fix-crash-when-exiting-kscreen-kcm-in-systemsettings.patch of Package kscreen5 (Revision d174dcdaf8115d2a6949e2bfd702135a)

Places