File 0004-mountd-don-t-add-paths-to-non-mounted-expo... of Package nfs-utils

Overview Repositories Revisions Requests Users Attributes Meta

File 0004-mountd-don-t-add-paths-to-non-mounted-export-points-.patch of Package nfs-utils (Revision 894d2a59f9cb909141d07bcd78e951f5)

Currently displaying revision 894d2a59f9cb909141d07bcd78e951f5 , Show latest

From fee5c26f320d1ea6b6fb45227ee75887555bd10d Mon Sep 17 00:00:00 2001
From: NeilBrown <neilb@suse.com>
Date: Wed, 13 Jul 2016 12:07:57 +1000
Subject: [PATCH] mountd: don't add paths to non-mounted export points to
 pseudo-root

export points with the "mountpoint" flag should not be exported
if they aren't mounted.
They shouldn't even appear in the pseudo-root filesystem.
So add an appropriate check to v4root_set().

This means that the v4root might need to be recomputed whenever a
filesystem is mounted or unmounted.  So when there are export points
with the "mountpoint" flag, check for changes in the mount table.
This is done be measuring the size of /proc/mounts.

Signed-off-by: NeilBrown <neilb@suse.com>
---
 support/include/v4root.h |    2 +-
 utils/mountd/auth.c      |   29 +++++++++++++++++++++++++++--
 utils/mountd/v4root.c    |   10 +++++++++-
 3 files changed, 37 insertions(+), 4 deletions(-)

--- a/support/include/v4root.h
+++ b/support/include/v4root.h
@@ -10,6 +10,6 @@
 #define V4ROOT_H
 
 extern int v4root_needed;
-extern void v4root_set(void);
+extern void v4root_set(int *mountpoints_checked);
 
 #endif /* V4ROOT_H */
--- a/utils/mountd/auth.c
+++ b/utils/mountd/auth.c
@@ -80,6 +80,29 @@ check_useipaddr(void)
 		cache_flush(1);
 }
 
+static int mountpoints_changed(void)
+{
+	static int last_size = 0;
+	int size;
+	int fd;
+	char buf[4096];
+	int n;
+
+	fd = open("/proc/mounts", O_RDONLY);
+	if (fd < 0)
+		/* ignore mountpoint changes if we cannot read /proc/mounts */
+		return 0;
+	size = 0;
+	while ((n = read(fd, buf, sizeof(buf))) > 0)
+		size += n;
+	if (n < 0)
+		return 0;
+	if (size == last_size)
+		return 0;
+	last_size = size;
+	return 1;
+}
+
 unsigned int
 auth_reload()
 {
@@ -87,13 +110,15 @@ auth_reload()
 	static ino_t		last_inode;
 	static int		last_fd;
 	static unsigned int	counter;
+	static int		mountpoints_checked = 0;
 	int			fd;
 
 	if ((fd = open(_PATH_ETAB, O_RDONLY)) < 0) {
 		xlog(L_FATAL, "couldn't open %s", _PATH_ETAB);
 	} else if (fstat(fd, &stb) < 0) {
 		xlog(L_FATAL, "couldn't stat %s", _PATH_ETAB);
-	} else if (stb.st_ino == last_inode) {
+	} else if (stb.st_ino == last_inode &&
+		   (!mountpoints_checked || !mountpoints_changed())) {
 		close(fd);
 		return counter;
 	} else {
@@ -106,7 +131,7 @@ auth_reload()
 	memset(&my_client, 0, sizeof(my_client));
 	xtab_export_read();
 	check_useipaddr();
-	v4root_set();
+	v4root_set(&mountpoints_checked);
 
 	++counter;
 
--- a/utils/mountd/v4root.c
+++ b/utils/mountd/v4root.c
@@ -179,7 +179,7 @@ static int v4root_add_parents(nfs_export
  * looking for components of the v4 mount.
  */
 void
-v4root_set()
+v4root_set(int *mountpoints_checked)
 {
 	nfs_export	*exp;
 	int	i;
@@ -189,6 +189,7 @@ v4root_set()
 	if (!v4root_support())
 		return;
 
+	*mountpoints_checked = 0;
 	for (i = 0; i < MCL_MAXTYPES; i++) {
 		for (exp = exportlist[i].p_head; exp; exp = exp->m_next) {
 			if (exp->m_export.e_flags & NFSEXP_V4ROOT)
@@ -204,6 +205,13 @@ v4root_set()
 				exp->m_export.e_flags |= NFSEXP_FSID;
 				exp->m_export.e_fsid = 0;
 			}
+			if (exp->m_export.e_mountpoint) {
+				*mountpoints_checked = 1;
+				if (!is_mountpoint(exp->m_export.e_mountpoint[0]?
+						   exp->m_export.e_mountpoint:
+						   exp->m_export.e_path))
+					continue;
+			}
 
 			v4root_add_parents(exp);
 			/* XXX: error handling! */

Places

File 0004-mountd-don-t-add-paths-to-non-mounted-export-points-.patch of Package nfs-utils (Revision 894d2a59f9cb909141d07bcd78e951f5)

Places