File 0001-Handle-applyPrefixes-with-an-empty-string.... of Package plasma-framework

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Handle-applyPrefixes-with-an-empty-string.patch of Package plasma-framework (Revision f8bdcf394d0b41691d23527e5a0615b3)

Currently displaying revision f8bdcf394d0b41691d23527e5a0615b3 , Show latest

From 547a34d346695295ce05499ae355203414412993 Mon Sep 17 00:00:00 2001
From: David Edmundson <kde@davidedmundson.co.uk>
Date: Fri, 10 Mar 2017 09:49:47 +0000
Subject: [PATCH] Handle applyPrefixes with an empty string

Summary:
When setting an empty QStringList as prefix, it can lead to unexpected results, such as the prefix not changing.

BUG: 377441

Reviewers: #plasma

Subscribers: plasma-devel, #frameworks

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D5000
---
 src/declarativeimports/core/framesvgitem.cpp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/declarativeimports/core/framesvgitem.cpp b/src/declarativeimports/core/framesvgitem.cpp
index 81f9e6376..8e6225f13 100644
--- a/src/declarativeimports/core/framesvgitem.cpp
+++ b/src/declarativeimports/core/framesvgitem.cpp
@@ -556,7 +556,13 @@ void FrameSvgItem::updateDevicePixelRatio()
 
 void FrameSvgItem::applyPrefixes()
 {
-    if (m_prefixes.isEmpty() || m_frameSvg->imagePath().isEmpty()) {
+
+    if (m_frameSvg->imagePath().isEmpty()) {
+        return;
+    }
+
+    if (m_prefixes.isEmpty()) {
+        m_frameSvg->setElementPrefix(QString());
         return;
     }
 
-- 
2.12.0

Places

File 0001-Handle-applyPrefixes-with-an-empty-string.patch of Package plasma-framework (Revision f8bdcf394d0b41691d23527e5a0615b3)

Places