File 0001-When-deleting-the-panel-the-notifications-... of Package plasma5-workspace

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-When-deleting-the-panel-the-notifications-applet-is-.patch of Package plasma5-workspace (Revision 857e56bafdf5f568d7c92ab2917d9009)

Currently displaying revision 857e56bafdf5f568d7c92ab2917d9009 , Show latest

From 58206408a35a0900b5678231b7aaf490b2a3ec10 Mon Sep 17 00:00:00 2001
From: Kai Uwe Broulik <kde@privat.broulik.de>
Date: Tue, 18 Apr 2017 23:46:16 +0200
Subject: [PATCH 1/4] When deleting the panel the notifications applet is in,
 the containment is being destroyed but the corona is still there and
 rightfully emits availableScreenRectChanged. This will cause us to crash when
 we try to access the no-longer existing containment.

CCBUG: 378508

Differential Revision: https://phabricator.kde.org/D5321
---
 applets/notifications/lib/notificationsapplet.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/applets/notifications/lib/notificationsapplet.cpp b/applets/notifications/lib/notificationsapplet.cpp
index 7b311542..4474c8c8 100644
--- a/applets/notifications/lib/notificationsapplet.cpp
+++ b/applets/notifications/lib/notificationsapplet.cpp
@@ -61,6 +61,12 @@ void NotificationsApplet::init()
 
 void NotificationsApplet::onScreenChanges()
 {
+    // when removing the panel the applet is in, the containment is being destroyed but its corona is still
+    // there, rightfully emitting availableScreenRectChanged and then we blow up if we try to access it.
+    if (!containment()) {
+        return;
+    }
+
     m_availableScreenRect = containment()->corona()->availableScreenRect(containment()->screen());
     Q_EMIT availableScreenRectChanged(m_availableScreenRect);
 }
-- 
2.12.0

Places

File 0001-When-deleting-the-panel-the-notifications-applet-is-.patch of Package plasma5-workspace (Revision 857e56bafdf5f568d7c92ab2917d9009)

Places