File openvswitch-CVE-2022-32166.patch of Package openvswitch.28518

Overview Repositories Revisions Requests Users Attributes Meta

File openvswitch-CVE-2022-32166.patch of Package openvswitch.28518

Index: openvswitch-2.11.5/lib/flow.c
===================================================================
--- openvswitch-2.11.5.orig/lib/flow.c
+++ openvswitch-2.11.5/lib/flow.c
@@ -3421,8 +3421,21 @@ minimask_expand(const struct minimask *m
 bool
 minimask_equal(const struct minimask *a, const struct minimask *b)
 {
-    return !memcmp(a, b, sizeof *a
-                   + MINIFLOW_VALUES_SIZE(miniflow_n_values(&a->masks)));
+    /* At first glance, it might seem that this can be reasonably optimized
+     * into a single memcmp() for the total size of the region.  Such an
+     * optimization will work OK with most implementations of memcmp() that
+     * proceed from the start of the regions to be compared to the end in
+     * reasonably sized chunks.  However, memcmp() is not required to be
+     * implemented that way, and an implementation that, for example, compares
+     * all of the bytes in both regions without early exit when it finds a
+     * difference, or one that compares, say, 64 bytes at a time, could access
+     * an unmapped region of memory if minimasks 'a' and 'b' have different
+     * lengths.  By first checking that the maps are the same with the first
+     * memcmp(), we verify that 'a' and 'b' have the same length and therefore
+     * ensure that the second memcmp() is safe. */
+    return (!memcmp(a, b, sizeof *a)
+            && !memcmp(a + 1, b + 1,
+                       MINIFLOW_VALUES_SIZE(miniflow_n_values(&a->masks))));
 }
 
 /* Returns true if at least one bit matched by 'b' is wildcarded by 'a',

Places

File openvswitch-CVE-2022-32166.patch of Package openvswitch.28518

Places