File 0181-net-remove-an-assert-call-in-eth_ge.patch of Package qemu-linux-user

Overview Repositories Revisions Requests Users Attributes Meta

File 0181-net-remove-an-assert-call-in-eth_ge.patch of Package qemu-linux-user (Revision dff26f22213ff904929e707505275437)

Currently displaying revision dff26f22213ff904929e707505275437 , Show latest

From: Prasad J Pandit <pjp@fedoraproject.org>
Date: Wed, 21 Oct 2020 11:35:50 +0530
Subject: net: remove an assert call in eth_get_gso_type

Git-commit: 7564bf7701f00214cdc8a678a9f7df765244def1
References: bsc#1178174, CVE-2020-27617

eth_get_gso_type() routine returns segmentation offload type based on
L3 protocol type. It calls g_assert_not_reached if L3 protocol is
unknown, making the following return statement unreachable. Remove the
g_assert call, it maybe triggered by a guest user.

Reported-by: Gaoning Pan <pgn@zju.edu.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 net/eth.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/eth.c b/net/eth.c
index ae5d881aaebb6f3d169446da7537..13a69df9b974a03b53348ee90c9e 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -16,6 +16,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "net/eth.h"
 #include "net/checksum.h"
 #include "qemu-common.h"
@@ -72,9 +73,8 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto)
             return VIRTIO_NET_HDR_GSO_TCPV6 | ecn_state;
         }
     }
-
-    /* Unsupported offload */
-    g_assert_not_reached();
+    qemu_log_mask(LOG_UNIMP, "%s: probably not GSO frame, "
+        "unknown L3 protocol: 0x%04"PRIx16"\n", __func__, l3_proto);
 
     return VIRTIO_NET_HDR_GSO_NONE | ecn_state;
 }

Places

File 0181-net-remove-an-assert-call-in-eth_ge.patch of Package qemu-linux-user (Revision dff26f22213ff904929e707505275437)

Places