openSUSE Build Service

Overview Repositories Revisions Requests Users Attributes Meta

File all.diff of Package gperiodic (Revision 6f88eefb47f6666f529f81e667bb0823)

Currently displaying revision 6f88eefb47f6666f529f81e667bb0823 , Show latest

From: Jan Engelhardt <jengelh@inai.de>
Date: 2015-03-15 11:57:37.631698089 +0100

fix blatant errors

gcc:
gperiodic.c: In function 'menu_file_exit':
gperiodic.c:169:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
gperiodic.c: In function 'main_prog':
gperiodic.c:481:9: warning: 'buff' may be used uninitialized in this function [-Wmaybe-uninitialized]
     free(buff);

rpmlint:
I: Program returns random data in a function
E: gperiodic no-return-in-nonvoid-function gperiodic.c:169
---
 gperiodic.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: gperiodic-3.0.0/gperiodic.c
===================================================================
--- gperiodic-3.0.0.orig/gperiodic.c
+++ gperiodic-3.0.0/gperiodic.c
@@ -166,6 +166,7 @@ void display_element_dialog( GtkWidget *
 GCallback menu_file_exit(void)
 {
     main_window_exit(NULL,NULL);
+    return NULL;
 }
 
 
@@ -321,7 +322,7 @@ void main_prog(void)
   int menu_num_items;
   GdkColor tooltip_color_bg, tooltip_color_fg;
   int red, gree, blue;
-  char *buff;
+  char *buff = NULL;
   int i;
 
   GtkWidget *menubar;

Places

File all.diff of Package gperiodic (Revision 6f88eefb47f6666f529f81e667bb0823)

Places