File 0001-src-avoid-pointless-p-p-p-next.patch of Package singular

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-src-avoid-pointless-p-p-p-next.patch of Package singular (Revision 794466eabdd9d0bbb72629ad82cb0cc0)

Currently displaying revision 794466eabdd9d0bbb72629ad82cb0cc0 , Show latest

From 05908a2f69373030a920746052cce57e714c0576 Mon Sep 17 00:00:00 2001
From: Jan Engelhardt <jengelh@inai.de>
Date: Mon, 2 Jan 2012 13:04:00 +0100
Subject: [PATCH] src: avoid pointless p = p = p->next;

With "#define pIter(p) ((p) = (p)->next)", "p = pIter(p)" expands to
"p = p = p->next".

monomials/p_polys.cc: In function 'void p_Monic(spolyrec*, ring)':
monomials/p_polys.cc:1500:17: warning: operation on 'p' may be
undefined [-Wsequence-point]
mpr_base.cc: In function 'spolyrec* monomAt(spolyrec*, int)':
mpr_base.cc:729:67: warning: operation on 'iter' may be undefined
[-Wsequence-point]
---
 numeric/mpr_base.cc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/numeric/mpr_base.cc b/numeric/mpr_base.cc
index 629118d..fd4d47c 100644
--- a/numeric/mpr_base.cc
+++ b/numeric/mpr_base.cc
@@ -726,7 +726,7 @@ poly monomAt( poly p, int i )
 {
   assume( i > 0 );
   poly iter= p;
-  for ( int j= 1; (j < i) && (iter!=NULL); j++ ) iter= pIter(iter);
+  for ( int j= 1; (j < i) && (iter!=NULL); j++ ) pIter(iter);
   return iter;
 }
 //<-
-- 
1.7.10.4

Places

File 0001-src-avoid-pointless-p-p-p-next.patch of Package singular (Revision 794466eabdd9d0bbb72629ad82cb0cc0)

Places