File singular-sequence-points.diff of Package singular

Overview Repositories Revisions Requests Users Attributes Meta

File singular-sequence-points.diff of Package singular (Revision a2434fc071129b8f8dda39ed11ee29ca)

Currently displaying revision a2434fc071129b8f8dda39ed11ee29ca , Show latest

parent 5ce06f33177608ad815deca2cb3036bf53f289b8 ()
commit 00c8cf5d39ea56b97687fcf22dc09e2aeb427303
Author: Jan Engelhardt <jengelh@medozas.de>
Date:   Mon Jan 2 13:04:00 2012 +0100

src: avoid pointless p = p = p->next;

With "#define pIter(p) ((p) = (p)->next)", "p = pIter(p)" expands to
"p = p = p->next".

monomials/p_polys.cc: In function 'void p_Monic(spolyrec*, ring)':
monomials/p_polys.cc:1500:17: warning: operation on 'p' may be
undefined [-Wsequence-point]
mpr_base.cc: In function 'spolyrec* monomAt(spolyrec*, int)':
mpr_base.cc:729:67: warning: operation on 'iter' may be undefined
[-Wsequence-point]
---
 libpolys/polys/monomials/p_polys.cc |    2 +-
 numeric/mpr_base.cc                 |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: Source/libpolys/polys/monomials/p_polys.cc
===================================================================
--- Source.orig/libpolys/polys/monomials/p_polys.cc
+++ Source/libpolys/polys/monomials/p_polys.cc
@@ -1497,7 +1497,7 @@ void p_Monic(poly p, const ring r)
     number n = n_Mult(p_GetCoeff(p, r), lcInverse, r->cf);
     n_Normalize(n,r->cf);
     p_SetCoeff(p, n, r);   // destroys old leading coefficient!
-    p = pIter(p);
+    pIter(p);
   }
   n_Delete(&lcInverse, r->cf);
   p = pp;
Index: Source/numeric/mpr_base.cc
===================================================================
--- Source.orig/numeric/mpr_base.cc
+++ Source/numeric/mpr_base.cc
@@ -726,7 +726,7 @@ poly monomAt( poly p, int i )
 {
   assume( i > 0 );
   poly iter= p;
-  for ( int j= 1; (j < i) && (iter!=NULL); j++ ) iter= pIter(iter);
+  for ( int j= 1; (j < i) && (iter!=NULL); j++ ) pIter(iter);
   return iter;
 }
 //<-

Places

File singular-sequence-points.diff of Package singular (Revision a2434fc071129b8f8dda39ed11ee29ca)

Places