File 0001-Fix-ryu_test-compilation-missing-cstring-f... of Package clickhouse

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-ryu_test-compilation-missing-cstring-for-memcpy-.patch of Package clickhouse (Revision da0aeaffea867a1364147e35aec7659b)

Currently displaying revision da0aeaffea867a1364147e35aec7659b , Show latest

From cbebb94f25e27d387ccb17ab2892313cefc83ca2 Mon Sep 17 00:00:00 2001
From: Azat Khuzhin <a3at.mail@gmail.com>
Date: Sun, 19 Jan 2020 14:14:41 +0300
Subject: [PATCH] Fix ryu_test compilation (missing <cstring> for memcpy) with
 libstdc++

libc++ has <cstring> in <string> while libstdc++ does not:

$ fgrep -r '#include <cstring>' /usr/include/c++/v1/
  /usr/bin/../include/c++/v1/vector:#include <cstring>
  /usr/bin/../include/c++/v1/ext/__hash:#include <cstring>
  /usr/bin/../include/c++/v1/memory:#include <cstring>
  /usr/bin/../include/c++/v1/algorithm:#include <cstring>
  /usr/bin/../include/c++/v1/string:#include <cstring>
  /usr/bin/../include/c++/v1/utility:#include <cstring>

$ fgrep -r '#include <cstring>' /usr/include/c++/9.2.0/
  /usr/include/c++/9.2.0/experimental/buffer:#include <cstring>
  /usr/include/c++/9.2.0/regex:#include <cstring>
  /usr/include/c++/9.2.0/x86_64-pc-linux-gnu/bits/stdc++.h:#include <cstring>
  /usr/include/c++/9.2.0/x86_64-pc-linux-gnu/32/bits/stdc++.h:#include <cstring>

$ clang++ -stdlib=libc++ -o /dev/null -c /tmp/test.cpp
  /tmp/test.cpp:7:30: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
          return memcpy(0, 0, 0);
                        ~      ^
  /tmp/test.cpp:7:30: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
          return memcpy(0, 0, 0);
                           ~   ^
  2 warnings generated.

$ clang++ -o /dev/null -c /tmp/test.cpp
  /tmp/test.cpp:7:16: error: use of undeclared identifier 'memcpy'; did you mean 'wmemcpy'?
          return memcpy(0, 0, 0);
                 ^~~~~~
                 wmemcpy
  /usr/include/wchar.h:262:17: note: 'wmemcpy' declared here
  extern wchar_t *wmemcpy (wchar_t *__restrict __s1,
                  ^
  1 error generated.
---
 dbms/src/IO/tests/ryu_test.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dbms/src/IO/tests/ryu_test.cpp b/dbms/src/IO/tests/ryu_test.cpp
index 0866f6afd3..d8c385f2d0 100644
--- a/dbms/src/IO/tests/ryu_test.cpp
+++ b/dbms/src/IO/tests/ryu_test.cpp
@@ -1,5 +1,6 @@
 #include <string>
 #include <iostream>
+#include <cstring>
 #include <ryu/ryu.h>
 
 
-- 
2.16.4

Places

File 0001-Fix-ryu_test-compilation-missing-cstring-for-memcpy-.patch of Package clickhouse (Revision da0aeaffea867a1364147e35aec7659b)

Places