File 0001-Fix-truncating-output-file-to-zero-length-... of Package mingw32-kmymoney5

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-truncating-output-file-to-zero-length-on-Windows.patch of Package mingw32-kmymoney5 (Revision e88f2c8136c594042ccac99998aa0e52)

Currently displaying revision e88f2c8136c594042ccac99998aa0e52 , Show latest

From 9e7ecccc009c7c3636f2263863570ea5724674e7 Mon Sep 17 00:00:00 2001
From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Sun, 9 May 2021 16:16:15 +0200
Subject: [PATCH] Fix truncating output file to zero length on Windows when
 using gpg encryption

BUG:436647
FIXED-IN:5.1.2
---
 kmymoney/plugins/xml/xmlstorage.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/kmymoney/plugins/xml/xmlstorage.cpp b/kmymoney/plugins/xml/xmlstorage.cpp
index 1b94784d0..89934b474 100644
--- a/kmymoney/plugins/xml/xmlstorage.cpp
+++ b/kmymoney/plugins/xml/xmlstorage.cpp
@@ -456,12 +456,13 @@ void XMLStorage::saveToLocalFile(const QString& localFile, IMyMoneyOperationsFor
     // Permissions to apply to new file
     QFileDevice::Permissions fmode = QFileDevice::ReadUser | QFileDevice::WriteUser;
 
-    // Create a temporary file if needed
+    // Create a temporary file when targeted file exists and not using gpg encryption because KGPGFile already uses a temporary file
     QString writeFile = localFile;
+    QString tmpWriteFile = localFile;
     QTemporaryFile tmpFile(writeFile);
     if (QFile::exists(localFile)) {
         tmpFile.open();
-        writeFile = tmpFile.fileName();
+        tmpWriteFile = tmpFile.fileName();
         tmpFile.close();
         // Since file is going to be replaced, stash the original permissions so they can be restored
         fmode = QFile::permissions(localFile);
@@ -502,6 +503,7 @@ void XMLStorage::saveToLocalFile(const QString& localFile, IMyMoneyOperationsFor
             device = std::unique_ptr<decltype(device)::element_type>(kgpg.release());
         }
     } else {
+        writeFile = tmpWriteFile;
         QFile *file = new QFile(writeFile);
         // The second parameter of KCompressionDevice means that KCompressionDevice will delete the QFile object
         device = std::unique_ptr<decltype(device)::element_type>(new KCompressionDevice{file, true, (plaintext) ? KCompressionDevice::None : COMPRESSION_TYPE});
-- 
2.30.0

Places

File 0001-Fix-truncating-output-file-to-zero-length-on-Windows.patch of Package mingw32-kmymoney5 (Revision e88f2c8136c594042ccac99998aa0e52)

Places