Request 1030894 (accepted)

You're not reviewing the full diff of request 1030894 , but the diff to the superseded request 1030154 (Show full diff)

Overview

Request 1030894 accepted

- U_Do-not-ignore-leave-events.patch
* fixes xwayland issue#1397, issue#1395

- Update to version 22.1.4
* xwayland: Aggregate scroll axis events to fix kinetic scrolling
* Forbid server grabs by non-WM on *rootless* XWayland
* xkb: Avoid length-check failure on empty strings.
* ci: remove redundant slash in libxcvt repository url
* dix: Skip more code in SetRootClip for ROOT_CLIP_INPUT_ONLY
* dix: Fix overzealous caching of ResourceClientBits()
* xwayland: Prevent Xserver grabs with rootless
* xwayland: Delay wl_surface destruction
* build: Bump wayland requirement to 1.18
* xwayland: set tag on our surfaces
* xwayland: Clear the "xwl-window" tag on unrealize
* xwayland: correct the type for the discrete scroll events
* xkb: fix some possible memleaks in XkbGetKbdByName
* xkb: length-check XkbGetKbdByName before accessing the fields
* xkb: length-check XkbListComponents before accessing the fields
* xkb: proof GetCountedString against request length attacks
- supersedes security patches:
* U_xkb-fix-some-possible-memleaks-in-XkbGetKbdByName.patch
* U_xkb-proof-GetCountedString-against-request-length-at.patch

Created by sndirsch about 2 years ago
In state accepted
Supersedes 1030154

Submit xwayland

Comments for request 1030894 0
Comments for request 1030154 10

Dominique Leuenberger (dimstar) - about 2 years ago

reviewer

https://openqa.opensuse.org/tests/2827176#step/sshxterm/5

This error happened repeatedly with this version of xwayland - and even moved from one staging to another when xwayland was moved (currently there is no other package in this staging, making it clearly an xwayland issue)

Stefan Dirsch (sndirsch) - about 2 years ago

author source maintainer

I don't understand this test. Sorry! I even don't know how openQA is testing Xwayland. I doubt that openQA is making any tests yet with Wayland, let alone with Xwayland running on top of Wayland for running X apps.

Dominique Leuenberger (dimstar) - about 2 years ago

reviewer

Actually, GNOME runs as Wayland compositor, xwayland usautostarted for xterm here.

This is confirmed in e.g https://openqa.opensuse.org/tests/2827176#step/x_vt/3 where we see xwayland running

Stefan Dirsch (sndirsch) - about 2 years ago

author source maintainer

Ok. but I still don't understand the test.

Dominique Leuenberger (dimstar) - about 2 years ago

reviewer

It's more an 'accident' that it shows an issue with xwayland...

Essentially it runs just xterm, and a 2nd xterm over ssh -X - and there we get nonsense on the keyboard buffer

Fabian Vogt (Vogtinator) - about 2 years ago

openQA uses Ctrl-D to close xterm and the next xterm gets a stuck d key. So I guess the key release event did somehow not get processed correctly.

Dominique Leuenberger (dimstar) - about 2 years ago

reviewer

For reference, the test description:

Package: xterm openssh
 # Summary: Ensure ssh X-forwarding is working
 # - Launch xterm
 # - Run "SSH_AUTH_SOCK=0 ssh -XC root@localhost xterm"
 # - Check if another xterm opened
 # - Check for "If you can see this text ssh-X-forwarding is working"
 # - Kill xterm

Stefan Dirsch (sndirsch) - about 2 years ago

author source maintainer

I can reproduce this now outside from openQA. Bisecting now ...

Dominique Leuenberger (dimstar) - about 2 years ago

reviewer

Awesome news!

Stefan Dirsch (sndirsch) - about 2 years ago

author source maintainer

SR#1030894 includes the fix. :-)