Overview
Request 1077258 accepted
Update to 6.5.0
- Created by Vogtinator
- In state accepted
- Supersedes 1077144
Request History
Vogtinator created request
Update to 6.5.0
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop accepted review
krop approved review
krop accepted request
Thanks for the review, I'll make the final changes in KDE:Qt6 directly
Do the
= %{real_version}
reflect what the CMake code does?Yes, Qt itself requires the exact version and the CMake stuff does the same
qt6-location.changes has a duplicate
-
# Broken and obsolete translations
Why are they upstream still?
I suspect they don't care. They're community translations IIRC
I wonder whether the qt6-translations split is really worth it. qtbase is the vast majority of its size, then only the designer files are really noticable. The others don't really matter much.
I suspect they're not for libraries. I'm not even sure qdebug / qcdebug can use translations if present
How are the translation packages meant to be pulled in?
That's the same %package header as what %lang_package creates
so if qt6-tools-designer is installed, the matching translation package is installed
Did you verify this? With lang packages, the magic actually happens in the dependency generators, which convert e.g.
/usr/share/locale/kf5/de/LC_MESSAGES/kcm_autostart.mo
intoProvides: locale(plasma5-workspace:de)
ok, my theory didn't work. I'll change back to the monolithic thing
LGTM otherwise