You're not reviewing the full diff of
request 1087942
, but the diff to the superseded
request 1087004
(Show full diff)
Overview
Loading...
reviewer
Hi there Callum,
First thanks for your efforts.
Would you mind adding the context for this change to the spec/changes file? Right now, one would use ls -l /var
in Tumbleweed and see run -> /run
.
author
source maintainer
FHS / systemd compliance
/var/run is to be phased out
reviewer
OK, that's a good reason. But could you put that in the changes file, so people in decade from now can know in a quick glance what that change was all about, please?
Login required, please
login
in order to comment
Request History
gmbr3 created request
- Add nm-runstatedir.patch: to correct rundir from /var/run to /run
for systemd FHS compatibility
gnome-review-bot accepted review
Check script succeeded
luc14n0 approved review
LGTM
luc14n0 accepted review
LGTM
dimstar accepted request
xin+
Thank you Callum. I'm going to send a request upstream making
runstatedir
configurable through a Meson option rather than hardcoded, let's see what they say.@dimstar, @factory-repo-checker, @sreeves1: review reminder