Overview
Request 1123261 accepted
- Remove move of config files to /usr/etc. Sioyek never has code to
read configs in that directory.
- add config as well to /etc. seems to break things if not
- add patch define-linux-standard-paths.patch. using `sed` is very brittle to use
- add env var CONFIG+=non_portable
- Created by uncomfyhalomacro
- In state accepted
- Supersedes 1123155
Is the code even reading config files from there? Considering that you had to re-add the config in /etc, I'd assume 'no'?
yep. it cannot read it at /usr/etc despite the script provided from the source build-linux.sh
having $PREFIX/etc
.
it seems to me, that install step was incomplete hence why i found many distros e.g. NixOS, Arch, copies the files instead of using make install
🙃
if it ignores files in /usr/etc, we should probably not copy them there.
just moving files there is never the goal - the UsrEtc move takes more effort, as the code needs to check etc for admin config and fallback to usr/etc for default config... Simply moving to usr and expecting the admin to change files there is even wronger than having the files in etc
alright. i will supersede this SR then. in a bit
Request History
uncomfyhalomacro created request
- Remove move of config files to /usr/etc. Sioyek never has code to
read configs in that directory.
- add config as well to /etc. seems to break things if not
- add patch define-linux-standard-paths.patch. using `sed` is very brittle to use
- add env var CONFIG+=non_portable
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:32"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:32"
dimstar accepted review
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:adi:32 got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:adi:32 got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:adi:32 got accepted.