You're not reviewing the full diff of
request 1141789
, but the diff to the superseded
request 1139768
(Show full diff)
Overview
Request 1141789 accepted
update to 2.49.1
- Created by ojkastl_buildservice
- In state accepted
- 6 package maintainers
- Supersedes 1139768
Loading...
target maintainer
Looks good. One note about the changelog.
We have to avoid the third itemization level and related large indentation [1]. It breaks the rendering in autobuild tooling.
[1] https://build.opensuse.org/request/show/1139768#diff_0_n26
author
source maintainer
target maintainer
Hmm, sorry, I was not aware of that. What do you propose? Basically this means we need to rework things like this?
* [FEATURE] PromQL: Add a promql-experimental-functions feature flag containing some new experimental PromQL functions. #13103 NOTE: More experimental functions might be added behind the same feature flag in the future. Added functions: - Experimental mad_over_time (median absolute deviation around the median) function. #13059 - Experimental sort_by_label and sort_by_label_desc functions allowing sorting returned series by labels. #11299
target maintainer
I'd suggest something like:
* [FEATURE] PromQL: Add a promql-experimental-functions feature flag containing some experimental PromQL functions: mad_over_time (median absolute deviation around the median), sort_by_label and sort_by_label_desc allowing sorting returned series by labels.
Login required, please
login
in order to comment
Request History
ojkastl_buildservice created request
update to 2.49.1
witekbedyk accepted request
Smoke tested. Looks good. Thanks
@dmaiocchi, @kwk, @ojkastl_buildservice, @witekbedyk: review reminder