You're not reviewing the full diff of
request 1147874
, but the diff to the superseded
request 1147606
(Show full diff)
Overview
Request 1147874 accepted
* Update to version 2.25.2,
* Do not disable any tests, fixed upstream.
- Created by badshah400
- In state accepted
- Supersedes 1147606
Loading...
target maintainer
Wouldn't it better to add those missing BuildRequires than skipping the tests? Are missing packages all what's missing for those tests to be run?
author
source maintainer
Good point and thanks for the review. I think the test in this specific pkg were disabled due to bugs in the tests themselves. I am checking if they are all fixed now and will resubmit soon.
Login required, please
login
in order to comment
Request History
badshah400 created request
* Update to version 2.25.2,
* Do not disable any tests, fixed upstream.
gnome-review-bot accepted review
Check script succeeded
gnome-review-bot approved review
Check script succeeded
mcalabkova accepted request
ok
Uh maybe gnome-review-bot needs a new name? Thought I had submitted this to GNOME:* by mistake.
Anyways, many thanks for the review.