Overview
Request 1148285 accepted
- Packaging improvements:
* Drop BuildRequires: golang-packaging. The original macros for
file movements into GOPATH are obsolete with Go modules.
* Drop autosetup -n arg only needed when archive and package
name differ
* Remove goprep macro which is no longer recommended
* Remove gobuild macro which is no longer recommended
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable
but none exist at this time.
* Drop mod=vendor, go1.14+ will detect vendor dir and auto-enable
* Remove goinstall macro which is no longer recommended
* Drop defattr(-,root,root) no longer needed with recent rpm (forwarded request 1148283 from jfkw)
Request History
jfkw created request
- Packaging improvements:
* Drop BuildRequires: golang-packaging. The original macros for
file movements into GOPATH are obsolete with Go modules.
* Drop autosetup -n arg only needed when archive and package
name differ
* Remove goprep macro which is no longer recommended
* Remove gobuild macro which is no longer recommended
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable
but none exist at this time.
* Drop mod=vendor, go1.14+ will detect vendor dir and auto-enable
* Remove goinstall macro which is no longer recommended
* Drop defattr(-,root,root) no longer needed with recent rpm (forwarded request 1148283 from jfkw)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:122"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:122"
dimstar accepted review
anag+factory accepted review
Staging Project openSUSE:Factory:Staging:adi:122 got accepted.
anag+factory approved review
Staging Project openSUSE:Factory:Staging:adi:122 got accepted.
anag+factory accepted request
Staging Project openSUSE:Factory:Staging:adi:122 got accepted.