Overview

Request 1148285 accepted

- Packaging improvements:
* Drop BuildRequires: golang-packaging. The original macros for
file movements into GOPATH are obsolete with Go modules.
* Drop autosetup -n arg only needed when archive and package
name differ
* Remove goprep macro which is no longer recommended
* Remove gobuild macro which is no longer recommended
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable
but none exist at this time.
* Drop mod=vendor, go1.14+ will detect vendor dir and auto-enable
* Remove goinstall macro which is no longer recommended
* Drop defattr(-,root,root) no longer needed with recent rpm (forwarded request 1148283 from jfkw)

Loading...
Request History
Jeff Kowalczyk's avatar

jfkw created request

- Packaging improvements:
* Drop BuildRequires: golang-packaging. The original macros for
file movements into GOPATH are obsolete with Go modules.
* Drop autosetup -n arg only needed when archive and package
name differ
* Remove goprep macro which is no longer recommended
* Remove gobuild macro which is no longer recommended
* Build PIE with pattern that may become recommended procedure:
%%ifnarch ppc64 GOFLAGS="-buildmode=pie" %%endif go build
A go toolchain buildmode default config would be preferable
but none exist at this time.
* Drop mod=vendor, go1.14+ will detect vendor dir and auto-enable
* Remove goinstall macro which is no longer recommended
* Drop defattr(-,root,root) no longer needed with recent rpm (forwarded request 1148283 from jfkw)


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:122"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:122"


Dominique Leuenberger's avatar

dimstar accepted review


Ana Guerrero's avatar

anag+factory accepted review

Staging Project openSUSE:Factory:Staging:adi:122 got accepted.


Ana Guerrero's avatar

anag+factory approved review

Staging Project openSUSE:Factory:Staging:adi:122 got accepted.


Ana Guerrero's avatar

anag+factory accepted request

Staging Project openSUSE:Factory:Staging:adi:122 got accepted.

openSUSE Build Service is sponsored by