Overview
Request 1153114 superseded
- Fix openssl version detection for 3.0.x.
- dd_rescue-ossl3-evpcipherctx.diff: There's an additional field
in the (private) struct _evp_cipher_ctx_st in openssl-3 since
3.0.6, which makes a difference on 32bit. (On 64bit, the effect
is hidden by the compiler's alignment rules.)
- Specify libopenssl-devel as BuildRequirements. This will select
openssl-3 on new distributions.
- Created by garloff
- In state superseded
-
Package maintainer:
garloff
- Supersedes 1153038
- Superseded by 1154455
Sidenote: I never understood why the build macro improvements are not backported to old SLES versions (here: SLESE12SP5), making it simple for new packages to be built on old distros. dd_rescue would happily compile on old distros, but here we see SLES12SP5 fail, which I can only ignore. (I keep some more spec file magic in my own build service project, but I understand that this is unwanted on Factory.)
Another sidenote: It looks to me like I can approve this SR myself, despite being the author. Is it because I happen to be maintainer? I guess it's still best practice to follow the four eyes principle and wait for someone else to approve (except for cases of emergency)?
Request History
garloff created request
- Fix openssl version detection for 3.0.x.
- dd_rescue-ossl3-evpcipherctx.diff: There's an additional field
in the (private) struct _evp_cipher_ctx_st in openssl-3 since
3.0.6, which makes a difference on 32bit. (On 64bit, the effect
is hidden by the compiler's alignment rules.)
- Specify libopenssl-devel as BuildRequirements. This will select
openssl-3 on new distributions.
superseded by 1154455
Thanks for the changes ! Just a minor remark, you use "%autosetup" with the changes, FMHO, you can remove the use of "%setup" from the %prep section, where %autosetup do the setup jobs and apply patches. The other way, would be to use %setup and %autopatch, but I may recommend to use %autosetup as you did :)
Also, may it have a reference to this bug: https://bugzilla.suse.com/show_bug.cgi?id=1219882 into the changelog, adding [bsc#1219882], it allows to easily link to an existing bug report. I think the first changelog entry may be a good option.
@garloff: review reminder
Thanks a lot, Valentin! I have done as suggested. So, when pushing new changes, do I need to create a new SR, superceding this one?
OK, superceded by https://build.opensuse.org/request/show/1154455 now.