Overview
Request 1159096 superseded
- Add clementine-cpp17.patch:
* Fixes build with TagLib and Protobuf now requiring C++17.
- Add clementine-protobuf.patch:
* Fixes build with protobuf 22 and higher.
- Add clementine-taglib2.patch:
* Fixes build with TagLib 2.
- Created by plater
- In state superseded
- Supersedes 1158781
- Superseded by 1160552
-
Open review for
factory-staging
Request History
plater created request
- Add clementine-cpp17.patch:
* Fixes build with TagLib and Protobuf now requiring C++17.
- Add clementine-protobuf.patch:
* Fixes build with protobuf 22 and higher.
- Add clementine-taglib2.patch:
* Fixes build with TagLib 2.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:11"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:11"
darix accepted review
Accepted review for by_group opensuse-review-team request 1159096 from user staging-bot
dimstar_suse declined request
can't install clementine-1.4.0~rc2-1.1.x86_64:
nothing provides libtag1 >= 1.8 needed by clementine-1.4.0~rc2.x86_64
libtag1 figures like this as explicit dep in the .spec file - so even though it is ported to taglib2 now, there is a spurious dep left
anag+factory reopened request
Reopened via staging workflow.
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:11"
anag+factory declined request
Declined via staging workflow.
The hardcoded Requests on taglib1 is problematic. taglib1 doesn't exist anymore in Factory since with the update to version 2 there was a soname bump and it's libtag2 now.