Overview

Request 1166228 revoked

I hope I am not loading too much work onto you

Loading...

Dominique Leuenberger's avatar

bogus dep - mis-interpretaton of the meson output



Dominique Leuenberger's avatar

g-i devel is not needed for this package


Dominique Leuenberger's avatar

requiring a library? 100% of all cases wrong


Dominique Leuenberger's avatar

you lost the fact that this was there to ensure XDG_DATA_DIR has proper user directories added for flatpak - app scan capability


Dominique Leuenberger's avatar
reviewer target maintainer

well, if you'd have taken my SR, the work for me would all have been done... but sadly, that's not what you did


Dominique Leuenberger's avatar
reviewer target maintainer

I submitted my branch to GNOME:Apps:

https://build.opensuse.org/request/show/1166239


Dominique Leuenberger's avatar

This should nornally be auto-detected when you BuildRequire: gobject-introspection


Richard Rahl's avatar

tried to do it your way, but it doesn't build https://build.opensuse.org/package/live_build_log/home:rrahl0/junction/openSUSE_Tumbleweed/x86_64


Dominique Leuenberger's avatar

BuildRequires: gtk4-tools => should probably be gtk4-devel (or pkgconfig(gtk4))


Dominique Leuenberger's avatar
reviewer target maintainer

branched it and first thing I noticed: this is not a noarch package :)

check /usr/bin/junction - it differs per architecture


Dominique Leuenberger's avatar
reviewer target maintainer

And this will need some fixes in gi-find-deps.. lovely :)

Request History
Richard Rahl's avatar

rrahl0 created request

I hope I am not loading too much work onto you


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar declined review

SRed my branch from earlier into GNOME:Apps - and branched from there to GNOME:Next ( to validate the gobject-introspection fix) - all set.


Dominique Leuenberger's avatar

dimstar declined request

SRed my branch from earlier into GNOME:Apps - and branched from there to GNOME:Next ( to validate the gobject-introspection fix) - all set.


Richard Rahl's avatar

rrahl0 reopened request


Richard Rahl's avatar

rrahl0 revoked request

openSUSE Build Service is sponsored by