You're not reviewing the full diff of
request 1219558
, but the diff to the superseded
request 1219550
(Show full diff)
Overview
Request 1219558 accepted
Cherry-pick SLE fix.
- Switch to gcc for compilation (bsc#1219008)
- Created by michals
- In state accepted
-
Package maintainers:
cyphar and
shunghsiyu
- Supersedes 1219550
Loading...
Request History
michals created request
Cherry-pick SLE fix.
- Switch to gcc for compilation (bsc#1219008)
shunghsiyu accepted request
LGTM. Ideally should have another SR to keep using Clang on Tumbleweed/Factory.
Since this is a SLE-only issue can't we do a
%bcondor something so that we still build with clang on openSUSE (for Factory at least)? Just an idea.It's not a SLE problem, it's a toolchain problem.
Also since s390 does not have lldb it's not possible to tell if this is still broken, and if the change fixes the problem.
Hmm, I don't recall why lldb-devel is needed, probably have to look into that.
Ah, that was added in 0.21 for improved DWARF support
I also prefer to still build with Clang on Tumbleweed/Factory. But that can probably come as a separate SR.
That should be done once the dependencies are available on s390 to make sure reverting to clang does not regress the bug.
@cyphar, @shunghsiyu: review reminder