Overview

Request 480778 superseded

This will be needed by a new version of klee.

Loading...

Dominique Leuenberger's avatar

sorry for being pedantic - but now I fail to see why there is still a main package provided - there is literally nothing in there that would make any sense.

My recommendation would be to have

  • source rpm called klee-uclibc (as-is)
  • binary package klee-uclibc-devel-static = which is in fact the only thing of interest

If you think the split as is makes sense, well, you're the maintainer of it and will get questions by confused users


Stephan Kulow's avatar

from my reading, this is 2.1+


Jiri Slaby's avatar
author source maintainer

Where did you read that? From COPYING.LIB.boilerplate: Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.


Dominique Leuenberger's avatar
+%files
+%defattr(-,root,root)
+%doc COPYING.LIB README README.klee TODO
+%dir %{_libdir}/%{name}/
+%dir %{_libdir}/%{name}/lib/
+%{_libdir}/%{name}/lib/libc.a

This is ONLY a static library? No headers, nothing?

In any case: please check the packaging guidelines about static libraries and how to package them (if really needed)

https://en.opensuse.org/openSUSE:Packaging_guidelines#Static_Libraries

TL;DR: static libs go into a -devel-static package


Jiri Slaby's avatar
author source maintainer

This is a special static library. It is an LLVM bitcode. So it is not ELF, but bca code. I am not sure the guidelines apply to that (we cannot create shared library of that and it is neither a classic static library).


Dominique Leuenberger's avatar

Kinda special case - I'd say the question would be: is this going to be used as BuildRequires for other packages and its content would end up in other code (as with usual static linking) - then we should follow the guideline with a -devel-static (mostly used to find what else needs a rebuild if this changes) - if not, we're probably fine (some documentation in the .spec file might help clear this question up in the future)


Jiri Slaby's avatar
author source maintainer

would end up in other code (as with usual static linking)

It will. So I created the devel-static subpackage and resubmitted.

Request History
Jiri Slaby's avatar

jirislaby created request

This will be needed by a new version of klee.


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Yuchen Lin's avatar

maxlin_factory added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:295"


Yuchen Lin's avatar

maxlin_factory accepted review

Picked openSUSE:Factory:Staging:adi:295


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo devel:tools:statica/openSUSE_Tumbleweed


Jiri Slaby's avatar

jirislaby superseded request

superseded by 481252

openSUSE Build Service is sponsored by