You're not reviewing the full diff of
request 493052
, but the diff to the superseded
request 479819
(Show full diff)
Overview
Loading...
Login required, please
login
in order to comment
The change is a good approach, but there are some problems:
%stop_on_removal and %restart_on_update are intended for sysvinit only. These should not be called with systemd.
Well, and I see nothing to fillup (install file from /var/adm/fillup-templates to /etc/sysconfig). So %fillup_only makes no sense, and %fillup_and_insserv should use -f (skip fillup parts).
If there is no special reason to support SLE11, feel free to drop support of sysvinit completely.
Login required, please
login
in order to comment