This request is superseded by
request 560191
(Show diff)
You're not reviewing the full diff of
request 559747
, but the diff to the superseded
request 559746
(Show full diff)
Overview
Request 559747 superseded
- Update desktop database upon ranger installation/removal
* Fixed desktop file by adding GenericName entry
using ranger.desktop.patch to that effect
- Created by alois
- In state superseded
- Supersedes 559746
- Superseded by 560191
- Open review for factory-staging
- Open review for repo-checker
Loading...
Request History
alois created request
- Update desktop database upon ranger installation/removal
* Fixed desktop file by adding GenericName entry
using ranger.desktop.patch to that effect
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
AndreasStieger accepted review
LGTM
The desktop_database_post(un) parts are wrong, it should be < 1330… Newer releases use filetriggers.
See the wiki + the rpmlint warnings.
As a consequence I think it would make more sense to add this desktop_database_post(un) macros as a maintenance update of ranger than in the development package, which is useful for Tumbleweed and Leap 15.0 which both do not need this macros.
See sr#560186.