Request 577170 (accepted)

You're not reviewing the full diff of request 577170 , but the diff to the superseded request 575753 (Show full diff)

Overview

Request 577170 accepted

Remove non-systemd things, obsolete fillup usage and
obsolete requirements. To Factory and Beyond! :D

Created by adamm almost 7 years ago
In state accepted
Supersedes 575753

Submit nsd

Comments for request 577170 0
Comments for request 575753 4

Dominique Leuenberger (dimstar) - almost 7 years ago

reviewer

+%define _rundir /run

%_rundir should only be defined if not already done by the distro. If defined, there should be never a reason to deviate from it

Dominique Leuenberger (dimstar) - almost 7 years ago

reviewer

+BuildRequires: systemd-devel

Please use pkgconfig(libsystemd) (if you really need the devel!?) or pkgconfig(systemd); in any case, the pkgconfig() variants are preferred, as this allows OBS to use the syetmd-mini packages, sufficient to build packages, but not sufficient to manage your runtime system (shortening the build time of the distro)

Adam Majer (adamm) - almost 7 years ago

author source maintainer

Yes, both of these things are not needed at all. Removed. I've removed non-systemd things too and obsolete fillup usage. Thanks for looking at this ;)

Dominique Leuenberger (dimstar) - almost 7 years ago

reviewer

Thanks for the comment! It's rare that the review team get's a positive echo for comments.

The more your words are appreciated