You're not reviewing the full diff of
request 582671
, but the diff to the superseded
request 580213
(Show full diff)
Overview
Loading...
Login required, please
login
in order to comment
reviewer
The line %{?smp_mflags} seems not needed in line 45 of the diff:
+make %{?_smp_mflags} %{?smp_mflags}
A question: is %make_build sufficient here?
Login required, please
login
in order to comment
Request History
dimstar created request
- Use SPDX3.0 license tags and package COPYING as %license.
dimstar accepted review
gnome-review-bot accepted review
Check script succeeded
Output of check script (non-fatal):
Unknown license 'LGPL-2.1-or-later'
gnome-review-bot approved review
Check script succeeded
Output of check script (non-fatal):
Unknown license 'LGPL-2.1-or-later'
dimstar accepted request
xin+