Overview

Request 666267 accepted

- Remove version dependency from Cython (boo#1121578).


Tomáš Chvátal's avatar

This is not true, the cython is needed also when there is incompatibility and you need to regenerate the content, ie like when we updated from cython 0.27 to 0.28 which broke quite few modules because they didn't have the dependency.


Alberto Planas Dominguez's avatar

Cython generate the .c files, that are inside the tar. Why do you need to generate it inside the spec file? For example, this package will not generate any .c from .pyx for any cython version that you have installed, so in this case setting a random version of cython in the buildrequire or removing it will generate the same code.


Tomáš Chvátal's avatar

I mean that you should pull in just cython, you don't need the version, that indeed is not required, in a case there is Cython 0.29 this package would suddenly break otherwise.


Alberto Planas Dominguez's avatar

Uhm I really do not get why should require Cython (without version) when Cython is never called during the build process.


Tomáš Chvátal's avatar

Upstream properly regenerates files if the Cython is present:

try: from Cython.Build import cythonize USE_CYTHON = True except ImportError: USE_CYTHON = False

And this avoids buildfails if the cython gets updated. Funny friendly issues like: https://build.opensuse.org/package/rdiff/devel:languages:python/python-http-parser?linkrev=base&rev=31


Request History
Alberto Planas Dominguez's avatar

aplanas created request

- Remove version dependency from Cython (boo#1121578).


Dirk Mueller's avatar

dirkmueller accepted request

openSUSE Build Service is sponsored by