You're not reviewing the full diff of
request 685488
, but the diff to the superseded
request 683690
(Show full diff)
Overview
Loading...
We need https://cgit.kde.org/plasma-framework.git/commit/?id=ebae2d63033647950cf0f9d97410723a8c7db1f3
target maintainer
Indeed.
And there seems to be a quite serious problem in kirigami as well:
https://mail.kde.org/pipermail/release-team/2019-March/011265.html
Yeah, with no fix available. I had a quick look and the conflict is not trivial and I don't know enough of kirigami to solve it myself.
target maintainer
It apparently needs another commit as well:
https://mail.kde.org/pipermail/release-team/2019-March/011267.html
author
target maintainer
Indeed, I'm holding things off until we have a fix for kirigami.
@Vogtinator, @alarrosa, @cgiboudeaux, @luca_b, @tittiatcoke, @wolfi323: review reminder
Login required, please
login
in order to comment
Should be fine now I think.
Although, there is one thing that somewhat bothers me: libKF5AuthCore5 now basically recommends libKF5Auth5, because libKF5Auth5-lang requires it.
Maybe we should rename the lang package (e.g. to libKF5AuthCore5-lang or kauth-lang)?
OTOH, it's probably good enough as-is and doesn't matter really.
And of course this could still be changed later if desired...
PS, I forgot: the manually added bug reference in ktexteditor.changes is still wrong (kde#40368 should be kde#403868), but that could also be changed afterwards IMHO...
Anything major? If not I'd like to push this tomorrow.