Request 686802 (superseded)

This request is superseded by request 691613 (Show diff)

You're not reviewing the full diff of request 686802 , but the diff to the superseded request 685616 (Show full diff)

Overview

Request 686802 superseded

- Initial release of the package based on version 0.175.
- Initial release of the Metamath book from 2019-03-07.
- Use date as version number for Metamath book, because it isn't
versioned alongside the program.
- Add a brief manual page.
- Fix dependency versions - since the book has a different version,
we need to be careful which version we refer to.

Created by aaronpuchert over 5 years ago
In state superseded
Supersedes 685616
Superseded by 691613
Open review for legal-auto
Open review for openSUSE:Factory:Staging:adi:117

Submit metamath

Comments for request 686802 3
Comments for request 685616 2

Richard Brown (RBrownSUSE) - over 5 years ago

reviewer

Spec says GPL-2.0-only

metamath/LICENSE.TXT reads as GPL-2.0+

Aaron Puchert (aaronpuchert) - over 5 years ago

author source maintainer

My understanding is that GPL-2.0-only and GPL-2.0-or-later only differ in their "Standard License Header". The actual license text should be the same.

Here we don't have any license headers, so I set GPL-2.0-only, to be on the safe side. Richard Stallman wrote about this (https://www.gnu.org/licenses/identify-licenses-clearly.html): "[...] I decided to give each developer a choice about allowing future versions. This meant developers could release a program under GNU GPL version 1 only, or release it under GPL version 1 or any later version. The way developers state their choice is in the license notice that goes at the start of each source file. That's where the GPL says the decision is stated." Later he writes: "Please put on each nontrivial file of the source release a license notice of the form shown at the end of the GPL version you are using."

My reading is that unless the license notice exists, we can't assume that the -or-later variant is intended.

Aaron Puchert (aaronpuchert) - over 5 years ago

author source maintainer

README.TXT says "The metamath program is copyright under the terms of the GNU GPL license version 2 or later." So you're right. I'll change this.

Dominique Leuenberger (dimstar) - over 5 years ago

reviewer

can't install metamath-book-20190307-5.2.noarch:
  nothing provides metamath = 20190307-5.2 needed by metamath-book-20190307-5.2.noarch
    (we have metamath-0.175-5.2.x86_64)
can't install metamath-data-0.175-5.2.noarch:
  nothing provides metamath = 20190307-5.2 needed by metamath-data-0.175-5.2.noarch
    (we have metamath-0.175-5.2.x86_64)

in %package books, you redefine %version, and as a result any %version reference thereafter refers to 20190307.

You can yse %VERSION} (all caps) to explicitly refer back to the version as defined in the preamble

Aaron Puchert (aaronpuchert) - over 5 years ago

author source maintainer

Thanks for the hint, I'll update the request.