Request 724518 (superseded)

This request is superseded by request 724530 (Show diff)

You're not reviewing the full diff of request 724518 , but the diff to the superseded request 723909 (Show full diff)

Overview

Request 724518 superseded

conmon is required by podman 1.5.0

Created by mvedovati about 5 years ago
In state superseded
Supersedes 723909
Superseded by 724530
Open review for licensedigger
Open review for factory-staging
Open review for opensuse-review-team

Submit conmon

Comments for request 724518 2
Comments for request 723909 4

Dominique Leuenberger (dimstar) - about 5 years ago

reviewer

correct would be PREFIX=%{_prefix}

Marco Vedovati (mvedovati) - about 5 years ago

author

thanks dimstar, new SR at 724530

Sascha Grunert (sgrunert) - over 5 years ago

Thanks Marco, I totally forgot about that!

Dominique Leuenberger (dimstar) - over 5 years ago

reviewer

+%{make} -< please don't use % indirection macros. %make_build would be the right one here (also for parallel build)

+%{_usr}/bin/ -> %{_bindir}

+%{__make} PREFIX=%{buildroot}%{_usr} install -> %make_install (and posisbly the makefile needs to learn about DESTDIR; mangling buildroot into PREFIX is most of the time wrong and leads to buildroot being being embedded into files where it should not be

Sascha Grunert (sgrunert) - over 5 years ago

I will fix that up and provide a new request, thanks! :)

Marco Vedovati (mvedovati) - about 5 years ago

author

New request here: https://build.opensuse.org/request/show/724518