You're not reviewing the full diff of
request 749084
, but the diff to the superseded
request 747221
(Show full diff)
Overview
Loading...
Login required, please
login
in order to comment
@StevenK, @TheBlackCat, @alarrosa, @aplanas, @czerw, @dirkmueller, @glaubitz, @mcepl, @mimi_vx, @posophe, @rjschwei, @scarabeus_iv, @sleep_walker, @tbechtold: review reminder
target maintainer
Why do you BuildRequire the module future twice?
I know it is not completely unprecedented, but do you really have to have all those files in %{_bindir} with .py extension?
And no, it is a bad idea to claim whole %{python_sitearch}/* … many things can hide behind so general glob. Could you be a little bit more specific? Which subdirectories this package creates?
target maintainer
Also, make sure rpmlint is silent. Leaving executable files behind you (happens quite often with files packaged on Windows) is a bad manner.
Login required, please
login
in order to comment