Overview
Request 851875 accepted
dsteuer requested to include this package into factory. It is needed by some R packages,
and is used in several scientific software packages (which are potentially-to-be-included-in-factory) as cdo or nco. The compat parts are not really needed, but they just provide some symlinks and do no harm.
Request has been enhanced with splitting off libudunits2-0 as requested
and some minor cleanup.
- Created by manfred999
- In state accepted
- Supersedes 849361
30+%if 0%{?suse_version} > 1310 && 0%{?is_opensuse} 31+BuildRequires: cunit-devel 32+%endif
is-opensuse should not be used, as it excludes (possibly future) SLE and can thus cause issues for Leap/
any distro that has suse_version > 1310 defined is openSUSE or SLE; so the is_opensuse condition should be implicit already,.
27+Source0: ftp://ftp.unidata.ucar.edu/pub/udunits/udunits-%{version}.tar.gz
based on that, the package should be called udunits; the version should not be part of the name (unless it's a compact package, but then the 'most recent version' generally is suffixless, and old versions introduced for compact get the old version as suffix
as for the name, upstreams seems to be quite messy themselves with what they provide as name. With this, I'd say udunits2 could be considered acceptable
135+%{_libdir}/libudunits2.so.*
This should be split out into a libudunits2-0 package, according to the shared library packaging policy (https://en.opensuse.org/openSUSE:Shared_library_packaging_policy)
Thanks for your review! - Renaming the package would be a bit unfortunate, as it is now 4 years in science repo and got several users, but not impossible of course. You are correct concerning the messy naming in upstream. - openSUSE: this would be actually a call for spec-cleaner. - it is quite possible that cunit is available in all supported packages nowadays, I will investigate. - I will look into splitting the package.
Should use --disable-static, then you don't need to remove .a afterwards.
Question: Do I need a %license tag in every sub-package? Some packages include this tag in every library sub-package, but not on the main package and not in the devel packages (e.g. hdf5), is this the way to go?
Request History
manfred999 created request
dsteuer requested to include this package into factory. It is needed by some R packages,
and is used in several scientific software packages (which are potentially-to-be-included-in-factory) as cdo or nco. The compat parts are not really needed, but they just provide some symlinks and do no harm.
Request has been enhanced with splitting off libudunits2-0 as requested
and some minor cleanup.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:92"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:92"
dimstar accepted review
licensedigger accepted review
ok
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:92 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:92 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:92 got accepted.