Request 856067: Submit libqt5-qtwebengine - openSUSE Build Service

You're not reviewing the full diff of request 856067 , but the diff to the superseded request 855955 (Show full diff)

Overview

Request 856067 accepted

- Fix build with ICU 68:
* Added icu-68.patch
* Added icu-68-2.patch

Created by gmbr3 almost 4 years ago
In state accepted
Supersedes 855955

Submit libqt5-qtwebengine

Comments for request 856067 0
Comments for request 855955 6

Login required, please login in order to comment

Fabian Vogt (favogt) - almost 4 years ago

Where is icu-68-2.patch from?

Fabian Vogt (favogt) - almost 4 years ago

# PATCH-FIX-UPSTREAM marker is missing

Luca Beltrame (luca_b) - almost 4 years ago

target maintainer

The second patch does not look like an upstream patch.

Christophe Giboudeaux (cgiboudeaux) - almost 4 years ago

it is, but from libxml2 https://gitlab.gnome.org/GNOME/libxml2/-/commit/b516ed189eb440e909f36baca1557b98e4d9ffd7

Christophe Giboudeaux (cgiboudeaux) - almost 4 years ago

the stdbool.h include isn't part of upstream change however. Why is this needed?

Callum Farmer (gmbr3) - almost 4 years ago

author

Stdbool.h defines true and false in C99

Login required, please login in order to comment

Request History

gmbr3 created request almost 4 years ago

- Fix build with ICU 68:
* Added icu-68.patch
* Added icu-68-2.patch

cgiboudeaux accepted request almost 4 years ago

openSUSE Build Service is sponsored by