Request 886073: Submit containerized-data-importer

You're not reviewing the full diff of request 886073 , but the diff to the superseded request 885445 (Show full diff)

Overview

Request 886073 accepted

Containerized-Data-Importer (CDI)

Created by vulyanov over 3 years ago
In state accepted
Supersedes 885445

Submit containerized-data-importer

Comments for request 886073 1
Comments for request 885445 4

Vasily Ulyanov (vulyanov) - over 3 years ago

author source maintainer

'csv-generator' tool seems not needed inside the container image. Decided to drop it. That should fix the conflict.

Vasily Ulyanov (vulyanov) - over 3 years ago

author source maintainer

We'd also need '%registry_path' macro defined in the prjconf, similar to how its done in https://build.opensuse.org/projects/Virtualization/prjconf:

# Define a registry path for kubevirt-manifests that points to registry location

# of the KubeVirt images built in the project

%registry_path registry.opensuse.org/virtualization/container/kubevirt

The macro is used to correctly fill the manifest templates. It should point to the proper paths in the container registry where the images are published.

Dominique Leuenberger (dimstar) - over 3 years ago

reviewer

found conflict of containerized-data-importer-operator-1.30.0-6.1.x86_64 with kubevirt-virt-operator-0.38.1-2.1.x86_64
  /usr/bin/csv-generator

Vasily Ulyanov (vulyanov) - over 3 years ago

author source maintainer

The conflicting packages are supposed to be installed in different containers:

kubevirt-virt-operator provides /usr/bin/csv-generator for virt-operator-container
containerized-data-importer-operator provides /usr/bin/csv-generator for cdi-operator-container

It is not expected to have them both on the same filesystem.

Dominique Leuenberger (dimstar) - over 3 years ago

reviewer

Then declare this knowledge with a Conflicts: rpm tag