You're not reviewing the full diff of
request 974537
, but the diff to the superseded
request 974518
(Show full diff)
Overview
Loading...
Login required, please
login
in order to comment
target maintainer
can we do this as a patch rather than sed statements?
target maintainer
IMO patches are generally more work, but it is easier to know when they are not needed. I mostly like sed scripts more than patches and I don't mind this usage (although it is longer it is perfectly understandable), but it is definitely a matter of taste.
target maintainer
I prefer patches as well, but as long as it is reported upstream, I can live with it.
Login required, please
login
in order to comment