You're not reviewing the full diff of
request 976933
, but the diff to the superseded
request 976212
(Show full diff)
Overview
Request 976933 accepted
KDE Frameworks 5.94 + respins
- Created by cgiboudeaux
- In state accepted
- Supersedes 976212
Loading...
target maintainer
LGTM. Release is next Saturday, correct?
author
yes
target maintainer
I guess a submission by Friday would work. In case you want to put this in K:F5 earlier feel free to do so (modulo objections from others), I don't have access to osc here.
Login required, please
login
in order to comment
Request History
cgiboudeaux created request
KDE Frameworks 5.94 + respins
wolfi323 accepted request
I think there's no need to wait longer (the download is public now). I'll update the changelogs as mentioned...
LGTM.
Some notes on the changelogs though...
ki18n.changes:
+ * autotests: Require minimum cmake version for ki18n_install
+ * KF5I18nConfig: Add missing find_dependency call
These two changes were in 5.93.0 already.
kcmutils.changes:
+ * KPluginModel: Add isSaveNeededChanged singal
Superfluous space between the
*and the text (andsingalshould besignal)kconfigwidgets.changes:
+ * Default copy construcor, assignment operator and detructor
Typos (
construcor,detrucor), superfluous space beforedetructor+ * Apply 1 suggestion(s) to 1 file(s)
could probably be removed
kwayland.changes:
+ * client: Bump plasmashell version to 7
The commit references kde#453578, that could be added to this line.
plasma-framework.changes:
- Drop upstream changes
I would rather say "upstream patches", as the actual changes are not being dropped... ;-)