Request History
pevik created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:59"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:59"
licensedigger accepted review
The legal review is accepted preliminary. The package may require actions later on.
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:59 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:59 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:59 got accepted.
I suggest to pick the actual fix instead: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2247053
but there is a reference to another "solution", which actually only prevents a warning for clang.
https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2241851
what is the problem when the build is changed to clang?
IMO that is invalid. flexible array members must be at the end according to the standard.
Line 14-19 make little sense if upstream prefers Clang anyway.
Lines 14-19 are required for Leap - even with clang, otherwise there will be build errors.
Ah, I see!