Request 1037250 (accepted)

Overview

Request 1037250 accepted

- Remove %release from mkversion because it makes the build irreproducible.

Created by dziobian almost 2 years ago
In state accepted
Package maintainers: maciek_borzecki, mardy.it, and zyga

Submit snapd

Comments for request 1037250 3

Zygmunt Krynicki (zyga) - almost 2 years ago

reviewer target maintainer

This looks reasonable but I don't have experience in the wider RPM/suse ecosystem. Is this other packages do as well?

Bruno Pitrus (dziobian) - almost 2 years ago

author source maintainer

There's a periodic thread on the factory mailinglist about reproducible builds, so yes.

The main problem for the user is that non-reproducible builds cause unnecessary package updates. In OBS, %release is generally outside of the control of the packager and should be considered non-deterministic.

Bruno Pitrus (dziobian) - almost 2 years ago

author source maintainer

Look at the build log:

[  582s] /usr/bin/snap differs in ELF sections
[  582s] --- old /usr/bin/snap (objdump)
[  582s] +++ new /usr/bin/snap (objdump)
[  582s] @@ -418118,7 +418118,7 @@
[  582s]   a62d00 76322f63 6f686f72 74732f76 322f736e  v2/cohorts/v2/sn
[  582s]   a62d10 61706374 6c2f7632 2f737973 74656d73  apctl/v2/systems
[  582s]   a62d20 30313233 34353637 38395f32 2e35372e  0123456789_2.57.
[  582s] - a62d30 352d312e 32313330 35313735 37383132  5-1.213051757812
[  582s] + a62d30 352d312e 32323330 35313735 37383132  5-1.223051757812
[  582s]   a62d40 353a2066 72616d65 2e73703d 3c616c6c  5: frame.sp=<all
[  582s]   a62d50 6f775f61 6e793e3c 6368616e 67652d69  ow_any><change-i
[  582s]   a62d60 643e3c69 636f6e5f 6e616d65 3e3c696e  d><icon_name><in

this clearly comes from %release.