Loading...
Request History
kukuk created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar accepted review
dimstar_suse set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:B"
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:B got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:B got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:B got accepted.
This needs work on systemd side:
https://github.com/systemd/systemd/blob/9f5bf99f1b296aeef3c84527b0a87f4734f1029c/meson.build#L2408
CC @fbui
Build fail log: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:B/systemd/standard/x86_64
Whatever systemd tries to solve with linking to /etc/environment: pam_env is reading many files and combine them to one, not only and simply this file. Beside that the used files are additional depending on the pam_env configuration. So this most likely did never work as somebody expected.
The arguments for systemd to parse /etc/environment directly (see https://github.com/systemd/systemd/pull/25546) aren't really convincing. The only downside is that modifying /etc/environment will require
systemctl --user daemon-reexec
instead ofsystemctl --user daemon-reload
but I don't it will make any difference for users in practice.Given the fact that pam_env is included in common-session, which in its turn is included by systemd-user, removing the symlink /usr/lib/environment.d/99-environment.conf symlink should require no other change and the env built by pam_env should continue to be part of the env of the user managers.
So I'll drop the symlink.