Overview

Request 1042746 superseded

- avoid file conflict on SLE15 and other older distributions


Dominique Leuenberger's avatar

17+%if %{?suse_version} && %{suse_version} > 1500

three errors in one line:

  • %if %{?suse_version} => if suse_version is not defined, you get an error (invalid syntax)
  • %{suse_version} > 1500 if suse_version is not defined, this is still being 'expanded' (well, not) and you get a string vs 1500 comparison
  • %{?suse_version} && %{suse_version} > 1500 in what case can suse_version be > 1500 and not be defined?

What you actually wanted to use is %if 0%{?suse_version} > 1500

Request History
Dirk Mueller's avatar

dirkmueller created request

- avoid file conflict on SLE15 and other older distributions


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse declined request

17+%if %{?suse_version} && %{suse_version} > 1500

three errors in one line:

* `%if %{?suse_version}` => if suse_version is not defined, you get an error (invalid syntax)
* `%{suse_version} > 1500` if suse_version is not defined, this is still being 'expanded' (well, not) and you get a string vs 1500 comparison
* `%{?suse_version} && %{suse_version} > 1500` in what case can suse_version be > 1500 and not be defined?

What you actually wanted to use is `%if 0%{?suse_version} > 1500`


Dirk Mueller's avatar

dirkmueller superseded request

superseded by 1043106

openSUSE Build Service is sponsored by