Overview
Request 1057786 accepted
- Add patch dc71304b.patch
* Handle script executable Zip archives
- Use [Pp]atch0 explicit to avoid warning as python.magic build time
- Modifying patches
* file-5.22-elf.dif
* file-5.19-printf.dif
* file-5.19-zip2.0.dif
* file-5.19-biorad.dif
* file-secure_getenv.patch
* file-5.28-btrfs-image.dif
- Remove patch file-zstd.patch now upstream
- Port patch file-5.42.dif and rename it to file-5.44.dif
- Update to 5.44:
* Handle nan's so that we don't get internal floating point exceptions
when they are enabled (Vincent Mihalkovic)
* PR/397: Restore the ability to process files from stdin immediately.
* fixed various clustefuzz issues
* Fix error detection for decompression code (Vincent Mihalkovic)
* Add MAGIC_NO_COMPRESS_FORK and use it to produce a more
meaningful error message if we are sandboxing.
* Add built-in lzip decompression support (Michal Gorny)
* Add built-in zstd decompression support (Martin Rodriguez Reboredo)
- Enable tests for python-magic (not python-python-magic)
- Run pre_checkin.sh to get correct source tar ball
- Update to 5.44
- Created by WernerFink
- In state accepted
- Supersedes 1057216
python-magic fails test suite:
[ 27s] self = <test.python_magic_test.MagicTest testMethod=test_extension>
[ 27s]
[ 27s] def test_extension(self):
[ 27s] try:
[ 27s] m = magic.Magic(extension=True)
[ 27s] > self.assert_values(m, {
[ 27s] # some versions return '' for the extensions of a gz file,
[ 27s] # including w/ the command line. Who knows...
[ 27s] 'test.gz': ('gz/tgz/tpz/zabw/svgz', '', '???'),
[ 27s] 'name_use.jpg': 'jpeg/jpg/jpe/jfif',
[ 27s] })
[ 27s]
[ 27s] test/python_magic_test.py:134:
[ 27s] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[ 27s] test/python_magic_test.py:53: in assert_values
[ 27s] self.assertIn(value, expected_value)
[ 27s] E AssertionError: 'gz/tgz/tpz/zabw/svgz/adz/kmy/xcfgz' not found in ('gz/tgz/tpz/zabw/svgz', '', '???')
[ 27s] =============================== warnings summary ===============================
The log https://build.opensuse.org/public/build/openSUSE:Factory:Staging:C/standard/x86_64/python-magic/_log does not show that ... where doe this come from?
Oh - that's the 2nd python-magic implementation...
we have: * python-magic (2nd spec from file; only used by very few things it seems) * python-python-magic (used by most packages)
I think this deserves some cleanup activity and a proper way forward
Just based on a hunch, this is also due to file - the other pkg in the same staging is rpm which 'only' adds a patch for new architectures (x86-64-v3 and such)
strip-nondeterminism seems to be a regression in file
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026976
Fix was committed upstream: https://github.com/file/file/commit/dc71304b3b1fd2ed5f7098d59fb7f6ef10cfdc85
The format defined in this patch still needs a fix in strip-nondeterminism too though, which I just submitted
The question rises is I should temporary add commit dc71304b3b1fd2ed5f7098d59fb7f6ef10cfdc85 as a patch
I think that will be the best for now. That will work in combination with the patch added to strip-nondeterminism.
The alternative is waiting for File 5.45 (or do local modifications to strip-nondeterminism which are not in line with upstream, but support the format printed by File 5.44)
Request History
WernerFink created request
- Add patch dc71304b.patch
* Handle script executable Zip archives
- Use [Pp]atch0 explicit to avoid warning as python.magic build time
- Modifying patches
* file-5.22-elf.dif
* file-5.19-printf.dif
* file-5.19-zip2.0.dif
* file-5.19-biorad.dif
* file-secure_getenv.patch
* file-5.28-btrfs-image.dif
- Remove patch file-zstd.patch now upstream
- Port patch file-5.42.dif and rename it to file-5.44.dif
- Update to 5.44:
* Handle nan's so that we don't get internal floating point exceptions
when they are enabled (Vincent Mihalkovic)
* PR/397: Restore the ability to process files from stdin immediately.
* fixed various clustefuzz issues
* Fix error detection for decompression code (Vincent Mihalkovic)
* Add MAGIC_NO_COMPRESS_FORK and use it to produce a more
meaningful error message if we are sandboxing.
* Add built-in lzip decompression support (Michal Gorny)
* Add built-in zstd decompression support (Martin Rodriguez Reboredo)
- Enable tests for python-magic (not python-python-magic)
- Run pre_checkin.sh to get correct source tar ball
- Update to 5.44
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:C as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:C"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:C"
dimstar accepted review
licensedigger accepted review
ok
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:C got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:C got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:C got accepted.
