Overview

Request 1076834 accepted

- Disable vulkan support, stop passing vulkan=enabled to meson.
Disable vulkan-devel Requires and BuildRequires.
- Disable pkgconfig(libavfilter) BuildRequires, upstream do not
enable ffmpeg support by default and we do not enable it, so no
need to carry the dependency.
- Use ldconfig_scriptlets macro.
- Pass build-testsuite=false, build-tests=false and
build-examples=false to meson, no longer build these as we are
not running or installing them anyway, save a lot on buildtime.

Loading...

Luciano Santos's avatar

We need to find out how to use multibuild with Meson.


Bjørn Lie's avatar
author source maintainer

Sure, but in this case, we: 1. Pull in the libavfilter/libavcodec ffmpeg stack, and the proced to not use it at all during build since we are not explicitly telling meson to do so (its experimental, and hence disabled by default upstream). 2. We do build test-suite and examples, but we never run it, nor install it during build. See Tests:

[   62s]   Build
[   62s]     Debugging       : False
[   62s]     Optimization    : plain
[   62s]     Introspection   : True
[   62s]     Documentation   : True
[   62s]     Man pages       : True
[   62s]     Testsuite       : True
[   62s]     Tests           : False
[   62s]     Demos           : True
[   62s]     Examples        : True

[   62s]   User defined options
snip....
[   62s]     wrap_mode       : nodownload
[   62s]     broadway-backend: true
[   62s]     build-tests     : false
[   62s]     cloudproviders  : enabled
[   62s]     colord          : enabled

So we might as well go ahead and not waste the obs time for now.


Bjørn Lie's avatar
author source maintainer

I can add https://gitlab.gnome.org/GNOME/gtk/-/issues/5581

quote:

Benjamin Otte    2 weeks ago
Maintainer

It's a good thing that GTK's ffmpeg support is experimental and disabled by default, 
so we can just remove the code if nobody turns up to fix things.


Luciano Santos's avatar

Yeah, I agree with the changes proposed. Just wanted to document the issue of multibuild plus Meson again :^P


Luciano Santos's avatar

I might take a stab at it at some point.


Luciano Santos's avatar

The one thing puzzling me is the gschema file move <puzzled face>


Bjørn Lie's avatar
author source maintainer

we install gschema files with the package/files that needs it - all the demo files are in the packge I moved it too. This is also a package that is not installed by default. The schmas package is installed by default, so we installed a gschemas file for things we did not install.


Luciano Santos's avatar

Ah, makes sense to me. Thanks for the info.

Request History
Bjørn Lie's avatar

iznogood created request

- Disable vulkan support, stop passing vulkan=enabled to meson.
Disable vulkan-devel Requires and BuildRequires.
- Disable pkgconfig(libavfilter) BuildRequires, upstream do not
enable ffmpeg support by default and we do not enable it, so no
need to carry the dependency.
- Use ldconfig_scriptlets macro.
- Pass build-testsuite=false, build-tests=false and
build-examples=false to meson, no longer build these as we are
not running or installing them anyway, save a lot on buildtime.


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


GNOME Review Bot's avatar

gnome-review-bot approved review

Check script succeeded


Luciano Santos's avatar

luc14n0 accepted request

LGTM. Accepting and forwarding.

openSUSE Build Service is sponsored by