Overview
Request 1076834 accepted
- Disable vulkan support, stop passing vulkan=enabled to meson.
Disable vulkan-devel Requires and BuildRequires.
- Disable pkgconfig(libavfilter) BuildRequires, upstream do not
enable ffmpeg support by default and we do not enable it, so no
need to carry the dependency.
- Use ldconfig_scriptlets macro.
- Pass build-testsuite=false, build-tests=false and
build-examples=false to meson, no longer build these as we are
not running or installing them anyway, save a lot on buildtime.
Request History
iznogood created request
- Disable vulkan support, stop passing vulkan=enabled to meson.
Disable vulkan-devel Requires and BuildRequires.
- Disable pkgconfig(libavfilter) BuildRequires, upstream do not
enable ffmpeg support by default and we do not enable it, so no
need to carry the dependency.
- Use ldconfig_scriptlets macro.
- Pass build-testsuite=false, build-tests=false and
build-examples=false to meson, no longer build these as we are
not running or installing them anyway, save a lot on buildtime.
gnome-review-bot accepted review
Check script succeeded
gnome-review-bot approved review
Check script succeeded
luc14n0 accepted request
LGTM. Accepting and forwarding.
We need to find out how to use multibuild with Meson.
Sure, but in this case, we: 1. Pull in the libavfilter/libavcodec ffmpeg stack, and the proced to not use it at all during build since we are not explicitly telling meson to do so (its experimental, and hence disabled by default upstream). 2. We do build test-suite and examples, but we never run it, nor install it during build. See Tests:
So we might as well go ahead and not waste the obs time for now.
I can add https://gitlab.gnome.org/GNOME/gtk/-/issues/5581
quote:
Yeah, I agree with the changes proposed. Just wanted to document the issue of multibuild plus Meson again :^P
I might take a stab at it at some point.
The one thing puzzling me is the gschema file move <puzzled face>
we install gschema files with the package/files that needs it - all the demo files are in the packge I moved it too. This is also a package that is not installed by default. The schmas package is installed by default, so we installed a gschemas file for things we did not install.
Ah, makes sense to me. Thanks for the info.