Overview

Request 1079097 accepted

- with switching to suggests making use of (n)compress no longer
needs to be limited to openSUSE

- suggests instead of require compress (see changelog below)

- require compress (ncompress package) on openSUSE; it's not
supported on SLE

- Drop n_no-compress-on-sle.patch and set XPM_PATH_COMPRESS instead
(xpmPipeThrough function returns NULL when the command is not
available; so same result as with the patch applied; that the
child process for executing 'compress' returns with exit(1)
doesn't matter much; it might even be useful to see the error
message ...)

- Depend also on /usr/bin/uncompress, not only /usr/bin/gzip;
Requiring binaries instead of packages resolves the file
conflict with busybox-gzip, which is used when building nginx
opensuse images; dep chain was: nginx -> libdg3 -> libXpm4 -> gzip
==> conflict with busybox-gzip

- Depend on /usr/bin/gzip, not gzip

Loading...

Fabian Vogt's avatar

You can drop the %if 0%{?is_opensuse} part. It's harmless on SLE and that way it also works with packagehub.


Stefan Dirsch's avatar
author source maintainer

Hmm. You mean on SLE nobody will ever look for suggests for his system? Or ignore the one for (n)compress then?


Stefan Dirsch's avatar
author source maintainer

Indeed - assuming we would have ncompress on packagehub, this then could be of use for SLE.


Fabian Vogt's avatar

Yes, also note that SLE packages are also used for Leap.


Stefan Dirsch's avatar
author source maintainer

Or do you mean there is no installSuggests for Zypp/YaST?


Fabian Vogt's avatar

There is none. It's just for presenting it to the user.


Stefan Dirsch's avatar
author source maintainer

Ok. Thanks! Will change this.

Request History
Stefan Dirsch's avatar

sndirsch created request

- with switching to suggests making use of (n)compress no longer
needs to be limited to openSUSE

- suggests instead of require compress (see changelog below)

- require compress (ncompress package) on openSUSE; it's not
supported on SLE

- Drop n_no-compress-on-sle.patch and set XPM_PATH_COMPRESS instead
(xpmPipeThrough function returns NULL when the command is not
available; so same result as with the patch applied; that the
child process for executing 'compress' returns with exit(1)
doesn't matter much; it might even be useful to see the error
message ...)

- Depend also on /usr/bin/uncompress, not only /usr/bin/gzip;
Requiring binaries instead of packages resolves the file
conflict with busybox-gzip, which is used when building nginx
opensuse images; dep chain was: nginx -> libdg3 -> libXpm4 -> gzip
==> conflict with busybox-gzip

- Depend on /usr/bin/gzip, not gzip


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:F as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:F"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:F"


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:F got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:F got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:F got accepted.

openSUSE Build Service is sponsored by